Re: [PATCH v2 2/4] fs: add FS_IOC_FSSETXATTRAT and FS_IOC_FSGETXATTRAT

Eric Biggers
2024-05-22T18:33:28Z

On Wed, May 22, 2024 at 07:23:15PM +0200, Andrey Albershteyn wrote:
> On 2024-05-22 09:38:56, Eric Biggers wrote:
> > On Wed, May 22, 2024 at 09:28:53AM -0700, Darrick J. Wong wrote:
> > >
> > > Do the other *at() syscalls prohibit dfd + path pointing to a different
> > > filesystem? It seems odd to have this restriction that the rest don't,
> > > but perhaps documenting this in the ioctl_xfs_fsgetxattrat manpage is ok.
> >
> > No, but they are arbitrary syscalls so they can do that. ioctls traditionally
> > operate on the specific filesystem of the fd.
> >
> > It feels like these should be syscalls, not ioctls.
>
> Won't it also be a bit weird to have FS_IOC_FS[S|G]ETXATTR as
> ioctls for normal files and a syscall for special files? When both
> are doing the same thing
>

Why would the syscalls be restricted to operating on special files?

- Eric