[PATCHSET v30.5 03/10] xfsprogs: bmap log intent cleanups

Darrick J. Wong
2024-06-03T18:49:27Z

Hi all,

The next major target of online repair are metadata that are persisted
in blocks mapped by a file fork. In other words, we want to repair
directories, extended attributes, symbolic links, and the realtime free
space information. For file-based metadata, we assume that the space
metadata is correct, which enables repair to construct new versions of
the metadata in a temporary file. We then need to swap the file fork
mappings of the two files atomically. With this patchset, we begin
constructing such a facility based on the existing bmap log items and a
new extent swap log item.

This series cleans up a few parts of the file block mapping log intent
code before we start adding support for realtime bmap intents. Most of
it involves cleaning up tracepoints so that more of the data extraction
logic ends up in the tracepoint code and not the tracepoint call site,
which should reduce overhead further when tracepoints are disabled.
There is also a change to pass bmap intents all the way back to the bmap
code instead of unboxing the intent values and re-boxing them after the
_finish_one function completes.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been running on the djcloud for months with no problems. Enjoy!
Comments and questions are, as always, welcome.

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=bmap-intent-cleanups-6.9

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=bmap-intent-cleanups-6.9
---
Commits in this patchset:
* libxfs: remove kmem_alloc, kmem_zalloc, and kmem_free
* libxfs: add a bi_entry helper
* libxfs: reuse xfs_bmap_update_cancel_item
* libxfs: add a xattr_entry helper
---
db/bmap_inflate.c | 2 +-
include/kmem.h | 10 +-------
libxfs/defer_item.c | 58 ++++++++++++++++++++++++---------------------
libxfs/init.c | 2 +-
libxfs/kmem.c | 32 ++++++++-----------------
libxlog/xfs_log_recover.c | 19 +++++++--------
repair/bmap_repair.c | 4 ++-
7 files changed, 55 insertions(+), 72 deletions(-)