Re: [PATCH v7 04/11] readahead: allocate folios with mapping_min_order in readahead

Pankaj Raghav (Samsung)
2024-06-17T16:39:44Z

On Mon, Jun 17, 2024 at 05:10:15PM +0100, Matthew Wilcox wrote:
> On Mon, Jun 17, 2024 at 04:04:20PM +0000, Pankaj Raghav (Samsung) wrote:
> > On Mon, Jun 17, 2024 at 01:32:42PM +0100, Matthew Wilcox wrote:
> > So the following can still be there from Hannes patch as we have a
> > stable reference:
> >
> > ractl->_workingset |= folio_test_workingset(folio);
> > - ractl->_nr_pages++;
> > + ractl->_nr_pages += folio_nr_pages(folio);
> > + i += folio_nr_pages(folio);
> > }
>
> We _can_, but we just allocated it, so we know what size it is already.
Yes.

> I'm starting to feel that Hannes' patch should be combined with this
> one.

Fine by me. @Hannes, is that ok with you?