Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in the page cache

Matthew Wilcox
2024-06-17T12:34:08Z

On Mon, Jun 17, 2024 at 09:58:37AM +0000, Pankaj Raghav (Samsung) wrote:
> > > @@ -2471,6 +2478,8 @@ static int filemap_create_folio(struct file *file,
> > > * well to keep locking rules simple.
> > > */
> > > filemap_invalidate_lock_shared(mapping);
> > > + /* index in PAGE units but aligned to min_order number of pages. */
> >
> > in PAGE_SIZE units? Maybe also make this a complete sentence?
> Yes, will do.

I'd delete the comment entirely. Anyone working on this code should
already know that folio indices are in units of PAGE_SIZE and must
be aligned, so I'm not sure what value this comment adds.