Re: [PATCH v7 04/11] readahead: allocate folios with mapping_min_order in readahead

Hannes Reinecke
2024-06-18T06:56:59Z

On 6/17/24 18:39, Pankaj Raghav (Samsung) wrote:
> On Mon, Jun 17, 2024 at 05:10:15PM +0100, Matthew Wilcox wrote:
>> On Mon, Jun 17, 2024 at 04:04:20PM +0000, Pankaj Raghav (Samsung) wrote:
>>> On Mon, Jun 17, 2024 at 01:32:42PM +0100, Matthew Wilcox wrote:
>>> So the following can still be there from Hannes patch as we have a
>>> stable reference:
>>>
>>> ractl->_workingset |= folio_test_workingset(folio);
>>> - ractl->_nr_pages++;
>>> + ractl->_nr_pages += folio_nr_pages(folio);
>>> + i += folio_nr_pages(folio);
>>> }
>>
>> We _can_, but we just allocated it, so we know what size it is already.
> Yes.
>
>> I'm starting to feel that Hannes' patch should be combined with this
>> one.
>
> Fine by me. @Hannes, is that ok with you?

Sure. I was about to re-send my patchset anyway, so feel free to wrap it in.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich