From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/5] xfs: verify buffer, inode, and dquot items every tx commit
Date: Thu, 13 Jun 2024 07:07:59 +0200 [thread overview]
Message-ID: <20240613050759.GD17048@lst.de> (raw)
In-Reply-To: <171821431846.3202459.15525351478656391595.stgit@frogsfrogsfrogs>
On Wed, Jun 12, 2024 at 10:47:50AM -0700, Darrick J. Wong wrote:
> + struct xfs_mount *mp = ip->i_mount;
> + struct xfs_dinode *dip;
> + xfs_failaddr_t fa;
> +
> + dip = kzalloc(mp->m_sb.sb_inodesize, GFP_KERNEL | GFP_NOFS);
> + if (!dip) {
> + ASSERT(dip != NULL);
> + return;
> + }
> +
> + xfs_inode_to_disk(ip, dip, 0);
> + xfs_dinode_calc_crc(mp, dip);
> + fa = xfs_dinode_verify(mp, ip->i_ino, dip);
> + if (fa) {
> + xfs_inode_verifier_error(ip, -EFSCORRUPTED, __func__, dip,
> + sizeof(*dip), fa);
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> + ASSERT(fa == NULL);
> + }
> + kfree(dip);
Doing abother malloc and per committed inode feels awfully expensive.
Overall this feels like the wrong tradeoff, at least for generic
debug builds.
next prev parent reply other threads:[~2024-06-13 5:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 17:46 [PATCHSET] xfs: random fixes for 6.10 Darrick J. Wong
2024-06-12 17:46 ` [PATCH 1/5] xfs: don't treat append-only files as having preallocations Darrick J. Wong
2024-06-13 6:03 ` Dave Chinner
2024-06-13 8:28 ` Christoph Hellwig
2024-06-17 5:03 ` Dave Chinner
2024-06-17 6:46 ` Christoph Hellwig
2024-06-17 23:28 ` Dave Chinner
2024-06-12 17:47 ` [PATCH 2/5] xfs: fix freeing speculative preallocations for preallocated files Darrick J. Wong
2024-06-12 17:47 ` [PATCH 3/5] xfs: restrict when we try to align cow fork delalloc to cowextsz hints Darrick J. Wong
2024-06-13 5:06 ` Christoph Hellwig
2024-06-14 4:13 ` Darrick J. Wong
2024-06-14 4:41 ` Christoph Hellwig
2024-06-14 5:27 ` Darrick J. Wong
2024-06-14 5:30 ` Christoph Hellwig
2024-06-12 17:47 ` [PATCH 4/5] xfs: allow unlinked symlinks and dirs with zero size Darrick J. Wong
2024-06-13 4:57 ` Christoph Hellwig
2024-06-12 17:47 ` [PATCH 5/5] xfs: verify buffer, inode, and dquot items every tx commit Darrick J. Wong
2024-06-13 5:07 ` Christoph Hellwig [this message]
2024-06-13 7:04 ` Dave Chinner
2024-06-14 3:49 ` Darrick J. Wong
2024-06-14 4:42 ` Christoph Hellwig
2024-06-14 5:23 ` Darrick J. Wong
2024-06-18 0:18 ` [PATCH v1.1 " Darrick J. Wong
2024-06-18 6:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613050759.GD17048@lst.de \
--to=hch@lst.de \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox