Re: [PATCH 5/5] xfs: verify buffer, inode, and dquot items every tx commit

Darrick J. Wong
2024-06-14T05:23:44Z

On Fri, Jun 14, 2024 at 06:42:38AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 13, 2024 at 08:49:49PM -0700, Darrick J. Wong wrote:
> > > Hence I think this should be pushed into a separate debug config
> > > sub-option. Make it something we can easily turn on with
> > > KASAN and lockdep when we our periodic costly extensive validation
> > > test runs.
> >
> > Do you want a CONFIG_XFS_DEBUG_EXPENSIVE=y guard, then? Some of the
> > bmbt scanning debug things might qualify for that too.
>
> Or EXPENSIVE_VALIDATION. Another option would be a runtime selection,
> but that feels like a bit too much to bother.

Yeah, probably. FWIW I haven't seen any increase in fstests runtime
since I added this debug patch. I suspect that the 512b allocations
for the inode easily come out of that slab and don't slow us down much.

--D