public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Bill O'Donnell <bodonnel@redhat.com>
Cc: linux-xfs@vger.kernel.org, cmaiolino@redhat.com
Subject: Re: [PATCH v2 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t
Date: Thu, 13 Jun 2024 20:54:45 -0700	[thread overview]
Message-ID: <20240614035445.GE6125@frogsfrogsfrogs> (raw)
In-Reply-To: <20240613211933.1169581-5-bodonnel@redhat.com>

On Thu, Jun 13, 2024 at 04:09:18PM -0500, Bill O'Donnell wrote:
> Use time_t instead of int for interval field.
> 
> Coverity-id: 1596599
> 
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>

Hopefully the intervals never get that big, but yes, we could use a time
interval type instead of the ever popular int.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  repair/progress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/repair/progress.c b/repair/progress.c
> index 2ce36cef..15455a99 100644
> --- a/repair/progress.c
> +++ b/repair/progress.c
> @@ -91,7 +91,7 @@ typedef struct msg_block_s {
>  	uint64_t	*done;
>  	uint64_t	*total;
>  	int		count;
> -	int		interval;
> +	time_t		interval;
>  } msg_block_t;
>  static msg_block_t 	global_msgs;
>  
> -- 
> 2.45.2
> 
> 

      reply	other threads:[~2024-06-14  3:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 21:09 [PATCH v2 0/4] xfsprogs: coverity fixes Bill O'Donnell
2024-06-13 21:09 ` [PATCH v2 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Bill O'Donnell
2024-06-14  3:50   ` Darrick J. Wong
2024-06-13 21:09 ` [PATCH v2 2/4] xfs_db: fix unitialized automatic struct ifake to 0 Bill O'Donnell
2024-06-14  3:50   ` Darrick J. Wong
2024-06-13 21:09 ` [PATCH v2 3/4] xfs_fsr: correct type in fsrprintf() call Bill O'Donnell
2024-06-14  3:54   ` Darrick J. Wong
2024-06-14 15:20     ` Bill O'Donnell
2024-06-13 21:09 ` [PATCH v2 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t Bill O'Donnell
2024-06-14  3:54   ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614035445.GE6125@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=bodonnel@redhat.com \
    --cc=cmaiolino@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox