From: "Darrick J. Wong" <djwong@kernel.org>
To: Bill O'Donnell <bodonnel@redhat.com>
Cc: linux-xfs@vger.kernel.org, cmaiolino@redhat.com
Subject: Re: [PATCH v3 3/4] xfs_fsr: correct type in fsrprintf() call
Date: Fri, 14 Jun 2024 10:24:42 -0700 [thread overview]
Message-ID: <20240614172442.GH6125@frogsfrogsfrogs> (raw)
In-Reply-To: <20240614160643.1879156-4-bodonnel@redhat.com>
On Fri, Jun 14, 2024 at 11:00:15AM -0500, Bill O'Donnell wrote:
> Use %lld instead of %d for howlong variable.
>
> Coverity-id: 1596598
>
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
Looks good now,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fsr/xfs_fsr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index fdd37756..06cc0552 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -426,7 +426,8 @@ fsrallfs(char *mtab, time_t howlong, char *leftofffile)
> fsdesc_t *fsp;
> struct stat sb, sb2;
>
> - fsrprintf("xfs_fsr -m %s -t %d -f %s ...\n", mtab, howlong, leftofffile);
> + fsrprintf("xfs_fsr -m %s -t %lld -f %s ...\n", mtab,
> + (long long)howlong, leftofffile);
>
> endtime = starttime + howlong;
> fs = fsbase;
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2024-06-14 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:00 [PATCH v3 0/4] xfsprogs: coverity fixes Bill O'Donnell
2024-06-14 16:00 ` [PATCH v3 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Bill O'Donnell
2024-06-14 16:00 ` [PATCH v3 2/4] xfs_db: fix unitialized automatic struct ifake to 0 Bill O'Donnell
2024-06-14 16:00 ` [PATCH v3 3/4] xfs_fsr: correct type in fsrprintf() call Bill O'Donnell
2024-06-14 16:46 ` Christoph Hellwig
2024-06-14 17:24 ` Darrick J. Wong [this message]
2024-06-14 16:00 ` [PATCH v3 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614172442.GH6125@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=bodonnel@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox