From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: zlang@redhat.com,
Allison Henderson <allison.henderson@oracle.com>,
Catherine Hoang <catherine.hoang@oracle.com>,
fstests@vger.kernel.org, guan@eryu.me, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 08/11] common: add helpers for parent pointer tests
Date: Wed, 19 Jun 2024 10:28:54 -0700 [thread overview]
Message-ID: <20240619172854.GS103034@frogsfrogsfrogs> (raw)
In-Reply-To: <ZnJ38HnvfHRbZR-s@infradead.org>
On Tue, Jun 18, 2024 at 11:17:20PM -0700, Christoph Hellwig wrote:
> > +++ b/common/parent
>
> Should the file and functions have an xfs_ prefix as it's all about
> xfs parent pointers, which won't be portable to other file systems?
> Or maybe just merge it into common/xfs?
I've been trying not to add to the clutter in common/xfs -- except for
the three parent pointers tests, nobody else needs those helpers. I
don't want to make every xfs fstest parse that stuff.
I'll prefix the pptr helpers though.
--D
next prev parent reply other threads:[~2024-06-19 17:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 0:46 [PATCHSET v13.5 3/6] fstests: adjust tests for xfs parent pointers Darrick J. Wong
2024-06-18 0:49 ` [PATCH 01/11] generic: test recovery of extended attribute updates Darrick J. Wong
2024-06-19 6:12 ` Christoph Hellwig
2024-06-18 0:49 ` [PATCH 02/11] xfs/206: filter out the parent= status from mkfs Darrick J. Wong
2024-06-19 6:12 ` Christoph Hellwig
2024-06-18 0:50 ` [PATCH 03/11] xfs/122: update for parent pointers Darrick J. Wong
2024-06-19 6:12 ` Christoph Hellwig
2024-06-18 0:50 ` [PATCH 04/11] populate: create hardlinks " Darrick J. Wong
2024-06-19 6:14 ` Christoph Hellwig
2024-06-19 17:00 ` Darrick J. Wong
2024-06-18 0:50 ` [PATCH 05/11] xfs/021: adapt golden output files " Darrick J. Wong
2024-06-19 6:14 ` Christoph Hellwig
2024-06-18 0:50 ` [PATCH 06/11] xfs/{018,191,288}: disable parent pointers for this test Darrick J. Wong
2024-06-19 6:15 ` Christoph Hellwig
2024-06-19 17:03 ` Darrick J. Wong
2024-06-18 0:51 ` [PATCH 07/11] xfs/306: fix formatting failures with parent pointers Darrick J. Wong
2024-06-19 6:16 ` Christoph Hellwig
2024-06-18 0:51 ` [PATCH 08/11] common: add helpers for parent pointer tests Darrick J. Wong
2024-06-19 6:17 ` Christoph Hellwig
2024-06-19 17:28 ` Darrick J. Wong [this message]
2024-06-18 0:51 ` [PATCH 09/11] xfs: add parent pointer test Darrick J. Wong
2024-06-19 6:17 ` Christoph Hellwig
2024-06-18 0:51 ` [PATCH 10/11] xfs: add multi link " Darrick J. Wong
2024-06-19 6:18 ` Christoph Hellwig
2024-06-18 0:52 ` [PATCH 11/11] xfs: add parent pointer inject test Darrick J. Wong
2024-06-19 6:18 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-06-20 20:53 [PATCHSET v13.6 3/6] fstests: adjust tests for xfs parent pointers Darrick J. Wong
2024-06-20 20:59 ` [PATCH 08/11] common: add helpers for parent pointer tests Darrick J. Wong
2024-06-21 4:36 ` Christoph Hellwig
2023-12-31 19:59 [PATCHSET v13.0 1/3] fstests: adjust tests for xfs parent pointers Darrick J. Wong
2023-12-27 13:48 ` [PATCH 08/11] common: add helpers for parent pointer tests Darrick J. Wong
2023-05-26 2:00 [PATCHSET RFC v12.0 00/11] fstests: adjust tests for xfs parent pointers Darrick J. Wong
2023-05-26 2:04 ` [PATCH 08/11] common: add helpers for parent pointer tests Darrick J. Wong
2023-04-06 19:16 [PATCHSET v11 00/11] fstests: adjust tests for xfs parent pointers Darrick J. Wong
2023-04-06 19:43 ` [PATCH 08/11] common: add helpers for parent pointer tests Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619172854.GS103034@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox