From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] xfs: simplify xfs_dax_fault
Date: Fri, 21 Jun 2024 07:05:58 +0200 [thread overview]
Message-ID: <20240621050558.GB15463@lst.de> (raw)
In-Reply-To: <20240620185026.GA103034@frogsfrogsfrogs>
On Thu, Jun 20, 2024 at 11:50:26AM -0700, Darrick J. Wong wrote:
> > + if (!IS_ENABLED(CONFIG_FS_DAX)) {
> > + ASSERT(0);
> > + return VM_FAULT_SIGBUS;
>
> Does this actually work if FS_DAX=n? AFAICT there's no !DAX stub for
> dax_iomap_fault, so won't that cause a linker error?
IS_ENABLED expands to a compile time constant, so the compiler eliminates
the call and no stub is needed.
next prev parent reply other threads:[~2024-06-21 5:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 11:53 clean up I/O path inode locking helpers and the page fault handler Christoph Hellwig
2024-06-19 11:53 ` [PATCH 1/6] xfs: move the dio write relocking out of xfs_ilock_for_iomap Christoph Hellwig
2024-06-20 18:40 ` Darrick J. Wong
2024-06-19 11:53 ` [PATCH 2/6] xfs: cleanup xfs_ilock_iocb_for_write Christoph Hellwig
2024-06-20 18:41 ` Darrick J. Wong
2024-06-19 11:53 ` [PATCH 3/6] xfs: simplify xfs_dax_fault Christoph Hellwig
2024-06-20 18:50 ` Darrick J. Wong
2024-06-21 5:05 ` Christoph Hellwig [this message]
2024-06-21 17:43 ` Darrick J. Wong
2024-06-19 11:53 ` [PATCH 4/6] xfs: refactor __xfs_filemap_fault Christoph Hellwig
2024-06-20 18:54 ` Darrick J. Wong
2024-06-21 5:08 ` Christoph Hellwig
2024-06-19 11:53 ` [PATCH 5/6] xfs: always take XFS_MMAPLOCK shared in xfs_dax_fault Christoph Hellwig
2024-06-20 18:56 ` Darrick J. Wong
2024-06-19 11:53 ` [PATCH 6/6] xfs: fold xfs_ilock_for_write_fault into xfs_write_fault Christoph Hellwig
2024-06-20 18:57 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-06-23 5:44 clean up I/O path inode locking helpers and the page fault handler v2 Christoph Hellwig
2024-06-23 5:44 ` [PATCH 3/6] xfs: simplify xfs_dax_fault Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621050558.GB15463@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox