From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/011: support byte-based grant heads are stored in bytes now
Date: Fri, 21 Jun 2024 09:20:55 -0700 [thread overview]
Message-ID: <20240621162055.GC3058325@frogsfrogsfrogs> (raw)
In-Reply-To: <20240621062903.GA16866@lst.de>
On Fri, Jun 21, 2024 at 08:29:03AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 20, 2024 at 12:56:06PM -0700, Darrick J. Wong wrote:
> > > + # The grant heads record reservations in bytes. For complex reasons
> > > + # beyond the scope fo this test, these aren't going to be exactly zero
> >
> > of
> >
> > Why aren't they going to be exactly zero?
>
> Given that frozen file systems always have a dirty log to force
> recovery after a crash we also have space granted to it.
Might as well say that in the comment, then.
"The grant heads record log reservations in bytes. Frozen filesystems
always have a dirty log to force recovery, so the grant heads won't be
exactly zero..."
With something like that
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
prev parent reply other threads:[~2024-06-21 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 7:23 [PATCH] xfs/011: support byte-based grant heads are stored in bytes now Christoph Hellwig
2024-06-20 19:56 ` Darrick J. Wong
2024-06-21 6:29 ` Christoph Hellwig
2024-06-21 16:20 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621162055.GC3058325@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=dchinner@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox