Re: [PATCH 10/10] xfs: reclaim speculative preallocations for append only files

Christoph Hellwig
2024-06-24T17:22:57Z

On Mon, Jun 24, 2024 at 10:06:18AM -0700, Darrick J. Wong wrote:
> On Mon, Jun 24, 2024 at 06:07:35PM +0200, Christoph Hellwig wrote:
> > On Mon, Jun 24, 2024 at 08:54:43AM -0700, Darrick J. Wong wrote:
> > > >
> > > > if (xfs_get_extsz_hint(ip) ||
> > > > - (ip->i_diflags &
> > > > - (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)))
> > > > + (ip->i_diflags & XFS_DIFLAG_PREALLOC))
> > >
> > > The last time you tried to remove XFS_DIFLAG_APPEND from this test, I
> > > noticed that there's some fstest that "fails" because the bmap output
> > > for an append-only file now stops at isize instead of maxbytes. Do you
> > > see this same regression?
> >
> > No. What test did you see it with? Any special mkfs or mount options?
>
> IIRC /think/ it was xfs/009. No particularly special mkfs/mount
> options, though my memory of 10 days ago is a bit hazy now. :(

009 was the case when I also removed the XFS_DIFLAG_PREALLOC check
accidentally in the very first version.