From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/10] xfs: reclaim speculative preallocations for append only files
Date: Mon, 24 Jun 2024 19:22:53 +0200 [thread overview]
Message-ID: <20240624172253.GA22044@lst.de> (raw)
In-Reply-To: <20240624170618.GN103057@frogsfrogsfrogs>
On Mon, Jun 24, 2024 at 10:06:18AM -0700, Darrick J. Wong wrote:
> On Mon, Jun 24, 2024 at 06:07:35PM +0200, Christoph Hellwig wrote:
> > On Mon, Jun 24, 2024 at 08:54:43AM -0700, Darrick J. Wong wrote:
> > > >
> > > > if (xfs_get_extsz_hint(ip) ||
> > > > - (ip->i_diflags &
> > > > - (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)))
> > > > + (ip->i_diflags & XFS_DIFLAG_PREALLOC))
> > >
> > > The last time you tried to remove XFS_DIFLAG_APPEND from this test, I
> > > noticed that there's some fstest that "fails" because the bmap output
> > > for an append-only file now stops at isize instead of maxbytes. Do you
> > > see this same regression?
> >
> > No. What test did you see it with? Any special mkfs or mount options?
>
> IIRC /think/ it was xfs/009. No particularly special mkfs/mount
> options, though my memory of 10 days ago is a bit hazy now. :(
009 was the case when I also removed the XFS_DIFLAG_PREALLOC check
accidentally in the very first version.
next prev parent reply other threads:[~2024-06-24 17:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 5:34 post-EOF block handling revamp Christoph Hellwig
2024-06-23 5:34 ` [PATCH 01/10] xfs: fix freeing speculative preallocations for preallocated files Christoph Hellwig
2024-06-24 15:30 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 02/10] xfs: remove the i_mode check in xfs_release Christoph Hellwig
2024-06-24 15:34 ` Darrick J. Wong
2024-06-24 15:50 ` Christoph Hellwig
2024-08-07 15:01 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 03/10] xfs: refactor f_op->release handling Christoph Hellwig
2024-06-24 15:35 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 04/10] xfs: don't bother returning errors from xfs_file_release Christoph Hellwig
2024-06-24 15:39 ` Darrick J. Wong
2024-06-24 15:51 ` Christoph Hellwig
2024-08-07 14:59 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 05/10] xfs: skip all of xfs_file_release when shut down Christoph Hellwig
2024-06-24 15:41 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 06/10] xfs: don't free post-EOF blocks on read close Christoph Hellwig
2024-06-24 15:43 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 07/10] xfs: only free posteof blocks on first close Christoph Hellwig
2024-06-24 15:46 ` Darrick J. Wong
2024-06-24 16:08 ` Christoph Hellwig
2024-06-24 16:49 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 08/10] xfs: check XFS_IDIRTY_RELEASE earlier in xfs_release_eofblocks Christoph Hellwig
2024-06-24 15:50 ` Darrick J. Wong
2024-06-24 15:54 ` Christoph Hellwig
2024-06-23 5:34 ` [PATCH 09/10] xfs: simplify extent lookup in xfs_can_free_eofblocks Christoph Hellwig
2024-06-24 15:51 ` Darrick J. Wong
2024-06-23 5:34 ` [PATCH 10/10] xfs: reclaim speculative preallocations for append only files Christoph Hellwig
2024-06-24 15:54 ` Darrick J. Wong
2024-06-24 16:07 ` Christoph Hellwig
2024-06-24 17:06 ` Darrick J. Wong
2024-06-24 17:22 ` Christoph Hellwig [this message]
2024-06-24 18:44 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624172253.GA22044@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox