From: Wengang Wang <wen.gang.wang@oracle.com>
To: linux-xfs@vger.kernel.org
Cc: wen.gang.wang@oracle.com
Subject: [PATCH 2/9] spaceman/defrag: pick up segments from target file
Date: Tue, 9 Jul 2024 12:10:21 -0700 [thread overview]
Message-ID: <20240709191028.2329-3-wen.gang.wang@oracle.com> (raw)
In-Reply-To: <20240709191028.2329-1-wen.gang.wang@oracle.com>
segments are the smallest unit to defragment.
A segment
1. Can't exceed size limit
2. contains some extents
3. the contained extents can't be "unwritten"
4. the contained extents must be contigous in file blocks
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
spaceman/defrag.c | 204 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 204 insertions(+)
diff --git a/spaceman/defrag.c b/spaceman/defrag.c
index c9732984..175cf461 100644
--- a/spaceman/defrag.c
+++ b/spaceman/defrag.c
@@ -14,6 +14,32 @@
#include "space.h"
#include "input.h"
+#define MAPSIZE 512
+/* used to fetch bmap */
+struct getbmapx g_mapx[MAPSIZE];
+/* current offset of the file in units of 512 bytes, used to fetch bmap */
+static long long g_offset = 0;
+/* index to indentify next extent, used to get next extent */
+static int g_ext_next_idx = -1;
+
+/*
+ * segment, the smallest unit to defrag
+ * it includes some contiguous extents.
+ * no holes included,
+ * no unwritten extents included
+ * the size is limited by g_segment_size_lmt
+ */
+struct defrag_segment {
+ /* segment offset in units of 512 bytes */
+ long long ds_offset;
+ /* length of segment in units of 512 bytes */
+ long long ds_length;
+ /* number of extents in this segment */
+ int ds_nr;
+ /* flag indicating if segment contains shared blocks */
+ bool ds_shared;
+};
+
/* defrag segment size limit in units of 512 bytes */
#define MIN_SEGMENT_SIZE_LIMIT 8192 /* 4MiB */
#define DEFAULT_SEGMENT_SIZE_LIMIT 32768 /* 16MiB */
@@ -78,6 +104,165 @@ defrag_check_file(char *path)
return true;
}
+/*
+ * get next extent in the file.
+ * Note: next call will get the same extent unless move_next_extent() is called.
+ * returns:
+ * -1: error happened.
+ * 0: extent returned
+ * 1: no more extent left
+ */
+static int
+defrag_get_next_extent(int fd, struct getbmapx *map_out)
+{
+ int err = 0, i;
+
+ /* when no extents are cached in g_mapx, fetch from kernel */
+ if (g_ext_next_idx == -1) {
+ g_mapx[0].bmv_offset = g_offset;
+ g_mapx[0].bmv_length = -1LL;
+ g_mapx[0].bmv_count = MAPSIZE;
+ g_mapx[0].bmv_iflags = BMV_IF_NO_HOLES | BMV_IF_PREALLOC;
+ err = ioctl(fd, XFS_IOC_GETBMAPX, g_mapx);
+ if (err == -1) {
+ perror("XFS_IOC_GETBMAPX failed");
+ goto out;
+ }
+ /* for stats */
+ g_ext_stats.nr_ext_total += g_mapx[0].bmv_entries;
+
+ /* no more extents */
+ if (g_mapx[0].bmv_entries == 0) {
+ err = 1;
+ goto out;
+ }
+
+ /* for stats */
+ for (i = 1; i <= g_mapx[0].bmv_entries; i++) {
+ if (g_mapx[i].bmv_oflags & BMV_OF_PREALLOC)
+ g_ext_stats.nr_ext_unwritten++;
+ if (g_mapx[i].bmv_oflags & BMV_OF_SHARED)
+ g_ext_stats.nr_ext_shared++;
+ }
+
+ g_ext_next_idx = 1;
+ g_offset = g_mapx[g_mapx[0].bmv_entries].bmv_offset +
+ g_mapx[g_mapx[0].bmv_entries].bmv_length;
+ }
+
+ map_out->bmv_offset = g_mapx[g_ext_next_idx].bmv_offset;
+ map_out->bmv_length = g_mapx[g_ext_next_idx].bmv_length;
+ map_out->bmv_oflags = g_mapx[g_ext_next_idx].bmv_oflags;
+out:
+ return err;
+}
+
+/*
+ * move to next extent
+ */
+static void
+defrag_move_next_extent()
+{
+ if (g_ext_next_idx == g_mapx[0].bmv_entries)
+ g_ext_next_idx = -1;
+ else
+ g_ext_next_idx += 1;
+}
+
+/*
+ * check if the given extent is a defrag target.
+ * no need to check for holes as we are using BMV_IF_NO_HOLES
+ */
+static bool
+defrag_is_target(struct getbmapx *mapx)
+{
+ /* unwritten */
+ if (mapx->bmv_oflags & BMV_OF_PREALLOC)
+ return false;
+ return mapx->bmv_length < g_segment_size_lmt;
+}
+
+static bool
+defrag_is_extent_shared(struct getbmapx *mapx)
+{
+ return !!(mapx->bmv_oflags & BMV_OF_SHARED);
+}
+
+/*
+ * get next segment to defragment.
+ * returns:
+ * -1 error happened.
+ * 0 segment returned.
+ * 1 no more segments to return
+ */
+static int
+defrag_get_next_segment(int fd, struct defrag_segment *out)
+{
+ struct getbmapx mapx;
+ int ret;
+
+ out->ds_offset = 0;
+ out->ds_length = 0;
+ out->ds_nr = 0;
+ out->ds_shared = false;
+
+ do {
+ ret = defrag_get_next_extent(fd, &mapx);
+ if (ret != 0) {
+ /*
+ * no more extetns, return current segment if its not
+ * empty
+ */
+ if (ret == 1 && out->ds_nr > 0)
+ ret = 0;
+ /* otherwise, error heppened, stop */
+ break;
+ }
+
+ /*
+ * If the extent is not a defrag target, skip it.
+ * go to next extent if the segment is empty;
+ * otherwise return the segment.
+ */
+ if (!defrag_is_target(&mapx)) {
+ defrag_move_next_extent();
+ if (out->ds_nr == 0)
+ continue;
+ else
+ break;
+ }
+
+ /* check for segment size limitation */
+ if (out->ds_length + mapx.bmv_length > g_segment_size_lmt)
+ break;
+
+ /* the segment is empty now, add this extent to it for sure */
+ if (out->ds_nr == 0) {
+ out->ds_offset = mapx.bmv_offset;
+ goto add_ext;
+ }
+
+ /*
+ * the segment is not empty, check for hole since the last exent
+ * if a hole exist before this extent, this extent can't be
+ * added to the segment. return the segment
+ */
+ if (out->ds_offset + out->ds_length != mapx.bmv_offset)
+ break;
+
+add_ext:
+ if (defrag_is_extent_shared(&mapx))
+ out->ds_shared = true;
+
+ out->ds_length += mapx.bmv_length;
+ out->ds_nr += 1;
+ defrag_move_next_extent();
+
+ } while (true);
+
+ return ret;
+}
+
/*
* defragment a file
* return 0 if successfully done, 1 otherwise
@@ -92,6 +277,9 @@ defrag_xfs_defrag(char *file_path) {
struct fsxattr fsx;
int ret = 0;
+ g_offset = 0;
+ g_ext_next_idx = -1;
+
fsx.fsx_nextents = 0;
memset(&g_ext_stats, 0, sizeof(g_ext_stats));
@@ -119,6 +307,22 @@ defrag_xfs_defrag(char *file_path) {
ret = 1;
goto out;
}
+
+ do {
+ struct defrag_segment segment;
+
+ ret = defrag_get_next_segment(defrag_fd, &segment);
+ /* no more segments, we are done */
+ if (ret == 1) {
+ ret = 0;
+ break;
+ }
+ /* error happened when reading bmap, stop here */
+ if (ret == -1) {
+ ret = 1;
+ break;
+ }
+ } while (true);
out:
if (scratch_fd != -1) {
close(scratch_fd);
--
2.39.3 (Apple Git-146)
next prev parent reply other threads:[~2024-07-09 19:10 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 19:10 [PATCH 0/9] introduce defrag to xfs_spaceman Wengang Wang
2024-07-09 19:10 ` [PATCH 1/9] xfsprogs: introduce defrag command to spaceman Wengang Wang
2024-07-09 21:18 ` Darrick J. Wong
2024-07-11 21:54 ` Wengang Wang
2024-07-15 21:30 ` Wengang Wang
2024-07-15 22:44 ` Darrick J. Wong
2024-07-09 19:10 ` Wengang Wang [this message]
2024-07-09 21:50 ` [PATCH 2/9] spaceman/defrag: pick up segments from target fileOM Darrick J. Wong
2024-07-11 22:37 ` Wengang Wang
2024-07-15 23:40 ` [PATCH 2/9] spaceman/defrag: pick up segments from target file Dave Chinner
2024-07-16 20:23 ` Wengang Wang
2024-07-17 4:11 ` Dave Chinner
2024-07-18 19:03 ` Wengang Wang
2024-07-19 4:59 ` Dave Chinner
2024-07-19 4:01 ` Christoph Hellwig
2024-07-24 19:22 ` Wengang Wang
2024-07-30 22:13 ` Dave Chinner
2024-07-09 19:10 ` [PATCH 3/9] spaceman/defrag: defrag segments Wengang Wang
2024-07-09 21:57 ` Darrick J. Wong
2024-07-11 22:49 ` Wengang Wang
2024-07-12 19:07 ` Wengang Wang
2024-07-15 22:42 ` Darrick J. Wong
2024-07-16 0:08 ` Dave Chinner
2024-07-18 18:06 ` Wengang Wang
2024-07-09 19:10 ` [PATCH 4/9] spaceman/defrag: ctrl-c handler Wengang Wang
2024-07-09 21:08 ` Darrick J. Wong
2024-07-11 22:58 ` Wengang Wang
2024-07-15 22:56 ` Darrick J. Wong
2024-07-16 16:21 ` Wengang Wang
2024-07-09 19:10 ` [PATCH 5/9] spaceman/defrag: exclude shared segments on low free space Wengang Wang
2024-07-09 21:05 ` Darrick J. Wong
2024-07-11 23:08 ` Wengang Wang
2024-07-15 22:58 ` Darrick J. Wong
2024-07-09 19:10 ` [PATCH 6/9] spaceman/defrag: workaround kernel xfs_reflink_try_clear_inode_flag() Wengang Wang
2024-07-09 20:51 ` Darrick J. Wong
2024-07-11 23:11 ` Wengang Wang
2024-07-16 0:25 ` Dave Chinner
2024-07-18 18:24 ` Wengang Wang
2024-07-31 22:25 ` Dave Chinner
2024-07-09 19:10 ` [PATCH 7/9] spaceman/defrag: sleeps between segments Wengang Wang
2024-07-09 20:46 ` Darrick J. Wong
2024-07-11 23:26 ` Wengang Wang
2024-07-11 23:30 ` Wengang Wang
2024-07-09 19:10 ` [PATCH 8/9] spaceman/defrag: readahead for better performance Wengang Wang
2024-07-09 20:27 ` Darrick J. Wong
2024-07-11 23:29 ` Wengang Wang
2024-07-16 0:56 ` Dave Chinner
2024-07-18 18:40 ` Wengang Wang
2024-07-31 3:10 ` Dave Chinner
2024-08-02 18:31 ` Wengang Wang
2024-07-09 19:10 ` [PATCH 9/9] spaceman/defrag: warn on extsize Wengang Wang
2024-07-09 20:21 ` Darrick J. Wong
2024-07-11 23:36 ` Wengang Wang
2024-07-16 0:29 ` Dave Chinner
2024-07-22 18:01 ` Wengang Wang
2024-07-30 22:43 ` Dave Chinner
2024-07-15 23:03 ` [PATCH 0/9] introduce defrag to xfs_spaceman Dave Chinner
2024-07-16 19:45 ` Wengang Wang
2024-07-31 2:51 ` Dave Chinner
2024-08-02 18:14 ` Wengang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709191028.2329-3-wen.gang.wang@oracle.com \
--to=wen.gang.wang@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox