[PATCH] xfs: convert comma to semicolon

[PATCH] xfs: convert comma to semicolon

[Chen Ni]

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/xfs/xfs_attr_list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
index 5c947e5ce8b8..7db386304875 100644
--- a/fs/xfs/xfs_attr_list.c
+++ b/fs/xfs/xfs_attr_list.c
@@ -139,7 +139,7 @@ xfs_attr_shortform_list(
 		sbp->name = sfe->nameval;
 		sbp->namelen = sfe->namelen;
 		/* These are bytes, and both on-disk, don't endian-flip */
-		sbp->value = &sfe->nameval[sfe->namelen],
+		sbp->value = &sfe->nameval[sfe->namelen];
 		sbp->valuelen = sfe->valuelen;
 		sbp->flags = sfe->flags;
 		sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,
-- 
2.25.1

Re: [PATCH] xfs: convert comma to semicolon

[Dave Chinner]

On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Fixes: 8f4b980ee67f ("xfs: pass the attr value to put_listent when possible")

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/xfs/xfs_attr_list.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 5c947e5ce8b8..7db386304875 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -139,7 +139,7 @@ xfs_attr_shortform_list(
>  		sbp->name = sfe->nameval;
>  		sbp->namelen = sfe->namelen;
>  		/* These are bytes, and both on-disk, don't endian-flip */
> -		sbp->value = &sfe->nameval[sfe->namelen],
> +		sbp->value = &sfe->nameval[sfe->namelen];
>  		sbp->valuelen = sfe->valuelen;
>  		sbp->flags = sfe->flags;
>  		sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,

Looks good,

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] xfs: convert comma to semicolon

[Darrick J. Wong]

On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---

LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  fs/xfs/xfs_attr_list.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 5c947e5ce8b8..7db386304875 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -139,7 +139,7 @@ xfs_attr_shortform_list(
>  		sbp->name = sfe->nameval;
>  		sbp->namelen = sfe->namelen;
>  		/* These are bytes, and both on-disk, don't endian-flip */
> -		sbp->value = &sfe->nameval[sfe->namelen],
> +		sbp->value = &sfe->nameval[sfe->namelen];
>  		sbp->valuelen = sfe->valuelen;
>  		sbp->flags = sfe->flags;
>  		sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,
> -- 
> 2.25.1
> 
> 

Re: [PATCH] xfs: convert comma to semicolon

[Chaitanya Kulkarni]

On 7/9/2024 12:36 AM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni<nichen@iscas.ac.cn>

Looks good.

Reviewed-by : Chaitanya Kulkarni <kch@nvidia.com>

-ck

[PATCH] xfs: convert comma to semicolon

[Chen Ni]

Replace a comma between expression statements by a semicolon.

Fixes: 178b48d588ea ("xfs: remove the for_each_xbitmap_ helpers")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/xfs/scrub/agheader_repair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/agheader_repair.c b/fs/xfs/scrub/agheader_repair.c
index 0dbc484b182f..2f98d90d7fd6 100644
--- a/fs/xfs/scrub/agheader_repair.c
+++ b/fs/xfs/scrub/agheader_repair.c
@@ -696,7 +696,7 @@ xrep_agfl_init_header(
 	 * step.
 	 */
 	xagb_bitmap_init(&af.used_extents);
-	af.agfl_bno = xfs_buf_to_agfl_bno(agfl_bp),
+	af.agfl_bno = xfs_buf_to_agfl_bno(agfl_bp);
 	xagb_bitmap_walk(agfl_extents, xrep_agfl_fill, &af);
 	error = xagb_bitmap_disunion(agfl_extents, &af.used_extents);
 	if (error)
-- 
2.25.1

Re: [PATCH] xfs: convert comma to semicolon

[Darrick J. Wong]

On Tue, Jul 16, 2024 at 04:01:12PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 178b48d588ea ("xfs: remove the for_each_xbitmap_ helpers")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/scrub/agheader_repair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/scrub/agheader_repair.c b/fs/xfs/scrub/agheader_repair.c
> index 0dbc484b182f..2f98d90d7fd6 100644
> --- a/fs/xfs/scrub/agheader_repair.c
> +++ b/fs/xfs/scrub/agheader_repair.c
> @@ -696,7 +696,7 @@ xrep_agfl_init_header(
>  	 * step.
>  	 */
>  	xagb_bitmap_init(&af.used_extents);
> -	af.agfl_bno = xfs_buf_to_agfl_bno(agfl_bp),
> +	af.agfl_bno = xfs_buf_to_agfl_bno(agfl_bp);
>  	xagb_bitmap_walk(agfl_extents, xrep_agfl_fill, &af);
>  	error = xagb_bitmap_disunion(agfl_extents, &af.used_extents);
>  	if (error)
> -- 
> 2.25.1
> 
> 

[PATCH] xfs: convert comma to semicolon

[Chen Ni]

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/xfs/libxfs/xfs_attr_remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
index 4c44ce1c8a64..5a55819f50f3 100644
--- a/fs/xfs/libxfs/xfs_attr_remote.c
+++ b/fs/xfs/libxfs/xfs_attr_remote.c
@@ -525,7 +525,7 @@ xfs_attr_rmtval_set_value(
 		ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
 		       (map.br_startblock != HOLESTARTBLOCK));
 
-		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
+		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock);
 		dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
 
 		error = xfs_buf_get(mp->m_ddev_targp, dblkno, dblkcnt, &bp);
-- 
2.25.1

Re: [PATCH] xfs: convert comma to semicolon

[Darrick J. Wong]

On Tue, Sep 03, 2024 at 03:39:31PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_attr_remote.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c
> index 4c44ce1c8a64..5a55819f50f3 100644
> --- a/fs/xfs/libxfs/xfs_attr_remote.c
> +++ b/fs/xfs/libxfs/xfs_attr_remote.c
> @@ -525,7 +525,7 @@ xfs_attr_rmtval_set_value(
>  		ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
>  		       (map.br_startblock != HOLESTARTBLOCK));
>  
> -		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
> +		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock);
>  		dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
>  
>  		error = xfs_buf_get(mp->m_ddev_targp, dblkno, dblkcnt, &bp);
> -- 
> 2.25.1
> 
> 

[PATCH] xfs: Convert comma to semicolon

[Chen Ni]

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/xfs/xfs_aops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index f279055fcea0..79ec98c8f299 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -792,7 +792,7 @@ xfs_vm_readahead(
 {
 	struct iomap_read_folio_ctx	ctx = { .rac = rac };
 
-	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
+	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
 	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
 }
 
-- 
2.25.1

Re: [PATCH] xfs: Convert comma to semicolon

[Carlos Maiolino]

On Fri, Mar 06, 2026 at 09:48:00AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index f279055fcea0..79ec98c8f299 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -792,7 +792,7 @@ xfs_vm_readahead(
>  {
>  	struct iomap_read_folio_ctx	ctx = { .rac = rac };
>  
> -	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
> +	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
>  	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
>  }

Yup, looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

>  
> -- 
> 2.25.1
> 
> 

RE: [PATCH] xfs: Convert comma to semicolon

[Joarder, Souptick]

-----Original Message-----
From: Chen Ni <nichen@iscas.ac.cn> 
Sent: Friday, March 6, 2026 7:18 AM
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org; linux-kernel@vger.kernel.org; Chen Ni <nichen@iscas.ac.cn>
Subject: [PATCH] xfs: Convert comma to semicolon

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Acked-by: Souptick Joarder <souptick.joarder@hpe.com>
---
 fs/xfs/xfs_aops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index f279055fcea0..79ec98c8f299 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -792,7 +792,7 @@ xfs_vm_readahead(
 {
 	struct iomap_read_folio_ctx	ctx = { .rac = rac };
 
-	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
+	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
 	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);  }
 
--
2.25.1

Re: [PATCH] xfs: Convert comma to semicolon

[Carlos Maiolino]

On Fri, Mar 06, 2026 at 09:48:00AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.

What tree HEAD did you apply this on?

I can't find where this code exists. I'm assuming you sent it against
some tree other than XFS's tree?

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index f279055fcea0..79ec98c8f299 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -792,7 +792,7 @@ xfs_vm_readahead(
>  {
>  	struct iomap_read_folio_ctx	ctx = { .rac = rac };
>  
> -	ctx.ops = xfs_get_iomap_read_ops(rac->mapping),
> +	ctx.ops = xfs_get_iomap_read_ops(rac->mapping);
>  	iomap_readahead(&xfs_read_iomap_ops, &ctx, NULL);
>  }
>  
> -- 
> 2.25.1
> 
> 

Re: [PATCH] xfs: Convert comma to semicolon

[Chen Ni]

On Tue, Mar 10, 2026 at 09:52:15AM +0100, Carlos Maiolino wrote:
> What tree HEAD did you apply this on?
> 
> I can't find where this code exists. I'm assuming you sent it against
> some tree other than XFS's tree?

Hi Carlos,

You are correct. This patch was based on linux-next commit 7407c0fbfa90,
which is not present in the current XFS tree.

Please disregard.

Best regards,
Chen Ni