public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] xfs: Remove duplicate xfs_trans_priv.h header
Date: Wed, 10 Jul 2024 19:55:00 -0700	[thread overview]
Message-ID: <20240711025500.GI612460@frogsfrogsfrogs> (raw)
In-Reply-To: <20240710024514.49176-1-jiapeng.chong@linux.alibaba.com>

On Wed, Jul 10, 2024 at 10:45:14AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_defer.c: xfs_trans_priv.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9491
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_defer.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c
> index 40021849b42f..2cd212ad2c1d 100644
> --- a/fs/xfs/libxfs/xfs_defer.c
> +++ b/fs/xfs/libxfs/xfs_defer.c
> @@ -28,7 +28,6 @@
>  #include "xfs_da_format.h"
>  #include "xfs_da_btree.h"
>  #include "xfs_attr.h"
> -#include "xfs_trans_priv.h"
>  #include "xfs_exchmaps.h"
>  
>  static struct kmem_cache	*xfs_defer_pending_cache;
> -- 
> 2.20.1.7.g153144c
> 
> 

      reply	other threads:[~2024-07-11  2:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10  2:45 [PATCH -next] xfs: Remove duplicate xfs_trans_priv.h header Jiapeng Chong
2024-07-11  2:55 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711025500.GI612460@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=abaci@linux.alibaba.com \
    --cc=chandan.babu@oracle.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox