From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: update XFS_IOC_DIOINFO memory alignment value
Date: Wed, 10 Jul 2024 21:36:14 -0700 [thread overview]
Message-ID: <20240711043614.GL612460@frogsfrogsfrogs> (raw)
In-Reply-To: <Zo9Zg762urtBzY1w@infradead.org>
On Wed, Jul 10, 2024 at 09:03:15PM -0700, Christoph Hellwig wrote:
> On Wed, Jul 10, 2024 at 07:52:06PM -0700, Darrick J. Wong wrote:
> > > - da.d_mem = da.d_miniosz = target->bt_logical_sectorsize;
> > > + da.d_mem = bdev_dma_alignment(target->bt_bdev);
> >
> > bdev_dma_alignment returns a mask, so I think you want to add one here?
>
> Yes.
>
> > Though at this point, perhaps DIOINFO should query the STATX_DIOALIGN
> > information so xfs doesn't have to maintain this anymore?
> >
> > (Or just make a helper that statx and DIOINFO can both call?)
>
> Lift DIOINFO to the VFS and back it using the statx data?
<shrug> Is there anything that DIOINFO provides that statx doesn't?
AFAICT XFS is the only fs that implements DIOINFO, so why expand that?
--D
next prev parent reply other threads:[~2024-07-11 4:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 0:36 [PATCH] xfs: update XFS_IOC_DIOINFO memory alignment value Dave Chinner
2024-07-11 2:52 ` Darrick J. Wong
2024-07-11 4:03 ` Christoph Hellwig
2024-07-11 4:36 ` Darrick J. Wong [this message]
2024-07-11 4:44 ` Christoph Hellwig
2024-07-11 5:52 ` Dave Chinner
2024-07-11 5:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711043614.GL612460@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox