Re: [PATCH v2 07/13] xfs: Introduce FORCEALIGN inode flag

Christoph Hellwig
2024-07-12T04:56:19Z

On Fri, Jul 12, 2024 at 09:20:26AM +1000, Dave Chinner wrote:
> I don't think we should error out the mount because reflink and
> forcealign are enabled - that's going to be the common configuration
> for every user of forcealign, right? I also don't think we should
> throw a corruption error if both flags are set, either.
>
> We're making an initial *implementation choice* not to implement the
> two features on the same inode at the same time. We are not making a
> an on-disk format design decision that says "these two on-disk flags
> are incompatible".

Oh, right forcealign is per-inode. In that case we just need to
ensure it never happens. Which honestly might be a bit confusing if
you can reflink for some files and not others, but that's a separate
discussion.