Re: [PATCH v2 00/13] forcealign for xfs

Christoph Hellwig
2024-07-09T07:48:05Z

On Mon, Jul 08, 2024 at 08:48:19AM +0100, John Garry wrote:
> I am not sure what that pain is, but I guess it's the maintainability and
> scalability of the scattered "if RT" checks for rounding up and down to
> larger extent size, right?
>
> For forcealign, at least we can factor that stuff mostly into common
> forcealign+RT helpers, to keep the checks common. That is apart from the
> block allocator code.

Maybe its just me hating all the rtalloc larger than block size
allocation granularity mess and hoping it goes away. With this we'll
make it certain that it is not going away, but that might just have
been a faint hope. But if we add more of it we'll at least need to
ensure it is done using common helpers and clean the existing mess up
as much as we can.