Re: [PATCH v2 07/13] xfs: Introduce FORCEALIGN inode flag

John Garry
2024-07-23T15:04:04Z

On 23/07/2024 15:42, Christoph Hellwig wrote:
> On Tue, Jul 23, 2024 at 11:11:28AM +0100, John Garry wrote:
>> I am looking at something like this to implement read-only for those inodes:
>
> Yikes. Treating individual inodes in a file systems as read-only
> is about the most confusing and harmful behavior we could do.

That was the suggestion which I was given earlier in this thread.

>
> Just treat it as any other rocompat feature please an mount the entire
> file system read-only if not supported.
>
> Or even better let this wait a little, and work with Darrick to work
> on the rextsize > 1 reflіnk patches and just make the thing work.

I'll let Darrick comment on this.

>
>>> So what about forcealign and RT?
>>
>> Any opinion on this?
>
> What about forcealign and RT?

In this series version I was mounting the whole FS as RO if
XFS_FEAT_FORCEALIGN and XFS_FEAT_REFLINK was found in the SB. And so
very different to how I was going to individual treat inodes which
happen to be forcealign and reflink, above.

So I was asking guidance when whether that approach (for RT and
forcealign) is sound.