From: Christoph Hellwig <hch@lst.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: RFC: don't fail tests when mkfs options collide
Date: Tue, 23 Jul 2024 16:20:13 +0200 [thread overview]
Message-ID: <20240723142013.GA20652@lst.de> (raw)
In-Reply-To: <20240723141724.GB2333818@mit.edu>
On Tue, Jul 23, 2024 at 10:17:24AM -0400, Theodore Ts'o wrote:
> > an allocation group (or block group in extN terms) to a specific size
> > and then want a log that is larger than that, changing the AG size
> > is generally a bad idea, and a clear warning to the user is simply the
> > better interface.
>
> Is it just "a bad idea", or "it won't work"?
Changing the AG size could work (assuming the file system size is
big enough, beause if it's not it obviously can't).
> I can imagine that
> sometimes we want to have tests that do things that are generally a
> bad idea, but it's the best way to force a particular corner case to
> happen without having to run the test gazillions of times?
If the test is written under the assumption of an AG size or number
of AGs, the expected output will change. So maybe the could would
run, sorta. But it would test something else and the test would
always fail.
next prev parent reply other threads:[~2024-07-23 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 0:00 RFC: don't fail tests when mkfs options collide Christoph Hellwig
2024-07-23 0:00 ` [PATCH 1/4] common: _notrun if _scratch_mkfs_sized failed Christoph Hellwig
2024-07-23 0:00 ` [PATCH 2/4] common: _notrun if _scratch_mkfs_xfs failed Christoph Hellwig
2024-07-26 17:14 ` Zorro Lang
2024-07-26 18:11 ` Christoph Hellwig
2024-07-28 14:54 ` Zorro Lang
2024-07-29 14:17 ` Christoph Hellwig
2024-07-23 0:00 ` [PATCH 3/4] xfs/432: use _scratch_mkfs_xfs Christoph Hellwig
2024-07-23 0:00 ` [PATCH 4/4] xfs/516: " Christoph Hellwig
2024-07-23 3:50 ` RFC: don't fail tests when mkfs options collide Theodore Ts'o
2024-07-23 13:39 ` Christoph Hellwig
2024-07-23 14:17 ` Theodore Ts'o
2024-07-23 14:20 ` Christoph Hellwig [this message]
2024-07-26 16:20 ` Darrick J. Wong
2024-07-26 17:11 ` Christoph Hellwig
2024-07-28 2:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723142013.GA20652@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox