Re: [PATCH 2/2] xfs/233: don't require rmap

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jul 29, 2024 at 07:20:27AM -0700, Christoph Hellwig wrote:
> Nothing in xfs/233 requires an rmap, it can run on any file system.
> And it is a very useful test because it starts out with a very small
> file system (or RT subvolume), which exercise some code paths no other
> test does.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Heh, you're right.  Lets do this! :)

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/xfs/233 | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/xfs/233 b/tests/xfs/233
> index 5d2c10e7d..211e5f842 100755
> --- a/tests/xfs/233
> +++ b/tests/xfs/233
> @@ -4,7 +4,7 @@
>  #
>  # FS QA Test No. 233
>  #
> -# Tests xfs_growfs on a rmapbt filesystem
> +# Tests xfs_growfs starting with a really small file system.
>  #
>  . ./common/preamble
>  _begin_fstest auto quick rmap growfs
> @@ -12,7 +12,6 @@ _begin_fstest auto quick rmap growfs
>  # Import common functions.
>  . ./common/filter
>  
> -_require_xfs_scratch_rmapbt
>  _require_no_large_scratch_dev
>  
>  echo "Format and mount"
> -- 
> 2.43.0
> 
>