From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 1/4] common: _notrun if _scratch_mkfs_sized failed
Date: Wed, 7 Aug 2024 07:35:07 -0700 [thread overview]
Message-ID: <20240807143519.2900711-2-hch@lst.de> (raw)
In-Reply-To: <20240807143519.2900711-1-hch@lst.de>
If we fail to create a file system of a specific size that means it can't
work with some of the options in $MKFS_OPTIONS like the log size. Don't
fail the test case for that, but instead _norun it and display the options
that caused it to fail.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Darrick J. Wong <djwong@kernel.org>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index afc33bbc2..93d366338 100644
--- a/common/rc
+++ b/common/rc
@@ -1168,7 +1168,7 @@ _try_scratch_mkfs_sized()
_scratch_mkfs_sized()
{
- _try_scratch_mkfs_sized $* || _fail "_scratch_mkfs_sized failed with ($*)"
+ _try_scratch_mkfs_sized $* || _notrun "_scratch_mkfs_sized failed with ($*)"
}
# Emulate an N-data-disk stripe w/ various stripe units
--
2.43.0
next prev parent reply other threads:[~2024-08-07 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 14:35 don't fail tests when mkfs options collide Christoph Hellwig
2024-08-07 14:35 ` Christoph Hellwig [this message]
2024-08-07 14:35 ` [PATCH 2/4] common: _notrun if _scratch_mkfs_xfs failed Christoph Hellwig
2024-08-07 14:35 ` [PATCH 3/4] xfs/432: use _scratch_mkfs_xfs Christoph Hellwig
2024-08-07 14:35 ` [PATCH 4/4] xfs/516: " Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-07-23 0:00 RFC: don't fail tests when mkfs options collide Christoph Hellwig
2024-07-23 0:00 ` [PATCH 1/4] common: _notrun if _scratch_mkfs_sized failed Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807143519.2900711-2-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox