Re: [PATCH 08/10] xfs: check XFS_IDIRTY_RELEASE earlier in xfs_release_eofblocks

Christoph Hellwig
2024-06-24T15:54:31Z

On Mon, Jun 24, 2024 at 08:50:22AM -0700, Darrick J. Wong wrote:
> On Sun, Jun 23, 2024 at 07:34:53AM +0200, Christoph Hellwig wrote:
> > If the XFS_IDIRTY_RELEASE flag is set, we are not going to free
>
> XFS_EOFBLOCKS_RELEASED ?

Yes.

> > the eofblocks, so don't bother locking the inode or performing the
> > checks in xfs_can_free_eofblocks.
>
> It'll still be the case that ->destroy_inode will have the chance to
> delete the eofblocks if we don't do it here, correct?

Yes.