Re: [PATCH 10/10] xfs: reclaim speculative preallocations for append only files

Christoph Hellwig
2024-06-24T16:07:39Z

On Mon, Jun 24, 2024 at 08:54:43AM -0700, Darrick J. Wong wrote:
> >
> > if (xfs_get_extsz_hint(ip) ||
> > - (ip->i_diflags &
> > - (XFS_DIFLAG_PREALLOC | XFS_DIFLAG_APPEND)))
> > + (ip->i_diflags & XFS_DIFLAG_PREALLOC))
>
> The last time you tried to remove XFS_DIFLAG_APPEND from this test, I
> noticed that there's some fstest that "fails" because the bmap output
> for an append-only file now stops at isize instead of maxbytes. Do you
> see this same regression?

No. What test did you see it with? Any special mkfs or mount options?