Re: [PATCH 04/10] xfs: don't bother returning errors from xfs_file_release

Christoph Hellwig
2024-06-24T15:51:27Z

On Mon, Jun 24, 2024 at 08:39:51AM -0700, Darrick J. Wong wrote:
> > +/*
> > + * Don't bother propagating errors. We're just doing cleanup, and the caller
> > + * ignores the return value anyway.
>
> Shouldn't we drop the int return from the function declaration, then?
>
> (Is that also a cleanup that's you're working on?)

We can't drop it without changing the f_ops->release signature and
updates to the many instance of it. That would still be worthwhile
project, but it's something for someone who is better at scripting
than me.