From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/6] xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc
Date: Thu, 22 Aug 2024 05:41:09 +0200 [thread overview]
Message-ID: <20240822034109.GB32681@lst.de> (raw)
In-Reply-To: <20240821160723.GA865349@frogsfrogsfrogs>
On Wed, Aug 21, 2024 at 09:07:23AM -0700, Darrick J. Wong wrote:
> On Tue, Aug 20, 2024 at 07:04:57PM +0200, Christoph Hellwig wrote:
> > Currently the debug-only xfs_bmap_exact_minlen_extent_alloc allocation
> > variant fails to drop into the lowmode last restor allocator, and
>
> last resort?
Yes.
> > + /*
> > + * Use the low space allocator as it first does a "normal" AG iteration
> > + * and then drops the reservation to minlen, which might be required to
> > + * find an allocation for the transaction reservation when the file
> > + * system is very full.
>
> Isn't it already doing a minlen allocation? Oh, that probably refers to
> shrinking args->total, doesn't it.
Yes, without this patch ap->total is left at the full value and never
reduced.
next prev parent reply other threads:[~2024-08-22 3:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 17:04 fix a DEBUG-only assert failure in xfs/538 Christoph Hellwig
2024-08-20 17:04 ` [PATCH 1/6] xfs: merge xfs_attr_leaf_try_add into xfs_attr_leaf_addname Christoph Hellwig
2024-08-21 15:52 ` Darrick J. Wong
2024-08-20 17:04 ` [PATCH 2/6] xfs: return bool from xfs_attr3_leaf_add Christoph Hellwig
2024-08-21 15:56 ` Darrick J. Wong
2024-08-20 17:04 ` [PATCH 3/6] xfs: distinguish extra split from real ENOSPC from xfs_attr3_leaf_split Christoph Hellwig
2024-08-21 15:57 ` Darrick J. Wong
2024-08-22 3:40 ` Christoph Hellwig
2024-08-20 17:04 ` [PATCH 4/6] xfs: fold xfs_bmap_alloc_userdata into xfs_bmapi_allocate Christoph Hellwig
2024-08-21 15:59 ` Darrick J. Wong
2024-08-20 17:04 ` [PATCH 5/6] xfs: call xfs_bmap_exact_minlen_extent_alloc from xfs_bmap_btalloc Christoph Hellwig
2024-08-21 8:24 ` Christoph Hellwig
2024-08-21 16:04 ` Darrick J. Wong
2024-08-20 17:04 ` [PATCH 6/6] xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc Christoph Hellwig
2024-08-21 16:07 ` Darrick J. Wong
2024-08-22 3:41 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-24 3:40 fix a DEBUG-only assert failure in xfs/538 v2 Christoph Hellwig
2024-08-24 3:40 ` [PATCH 6/6] xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc Christoph Hellwig
2024-08-27 8:39 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822034109.GB32681@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox