Re: [PATCH 1/1] xfs: introduce new file range commit ioctls

Christoph Hellwig
2024-08-24T03:29:19Z

On Fri, Aug 23, 2024 at 10:41:40AM -0700, Darrick J. Wong wrote:
> <nod> If these both get merged for 6.12, I think the appropriate port
> for this patch is to change xfs_ioc_start_commit to do:
>
> struct kstat kstat;
>
> fill_mg_cmtime(&kstat, STATX_CTIME | STATX_MTIME, XFS_I(ip2));
> kern_f->file2_ctime = kstat.ctime.tv_sec;
> kern_f->file2_ctime_nsec = kstat.ctime.tv_nsec;
> kern_f->file2_mtime = kstat.mtime.tv_sec;
> kern_f->file2_mtime_nsec = kstat.mtime.tv_nsec;
>
> instead of open-coding the inode_get_[cm]time calls. The entire
> exchangerange feature is still marked experimental, so I didn't think it
> was worth rebasing my entire dev branch on the multigrain timestamp
> redux series; we can just fix it later.

But the commit log could really note this dependency. This will be
especially useful for backports, but also for anyone reading through
code history.