Re: [PATCH 02/10] iomap: improve shared block detection in iomap_unshare_iter

Christoph Hellwig
2024-08-27T05:48:01Z

On Mon, Aug 26, 2024 at 10:44:24PM -0700, Darrick J. Wong wrote:
> Maybe we should rename it then?
>
> IOMAP_F_OUT_OF_PLACE_WRITE.
>
> Yuck.
>
> IOMAP_F_ELSEWHERE
>
> Not much better. Maybe just add a comment that "IOMAP_F_SHARED" really
> just means an out of place write (aka srcmap is not just a hole).

Heh.

For writes it usually means out of place write, but for reporting
it gets translated to the FIEMAP_EXTENT_SHARED flag or is used to
reject swapon. And the there is black magic in DAX.