public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Zizhi Wo <wozizhi@huawei.com>
Cc: chandan.babu@oracle.com, dchinner@redhat.com, osandov@fb.com,
	john.g.garry@oracle.com, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, yangerkun@huawei.com
Subject: Re: [PATCH 0/2] Some boundary error bugfix related to XFS fsmap.
Date: Mon, 2 Sep 2024 12:08:28 -0700	[thread overview]
Message-ID: <20240902190828.GA6224@frogsfrogsfrogs> (raw)
In-Reply-To: <9337ebda-8e27-4754-bc57-748e44f3b5e0@huawei.com>

On Thu, Aug 29, 2024 at 07:24:55PM +0800, Zizhi Wo wrote:
> friendly ping

Sorry, I'm not going to get to this until late September.

--D

> 在 2024/8/26 11:10, Zizhi Wo 写道:
> > Prior to this, I had already sent out a patchset related to xfs fsmap
> > bugfix, which mainly introduced "info->end_daddr" to fix omitted extents[1]
> > and Darrick had already sent out a patchbomb for merging into stable[2],
> > which included my previous patches.
> > 
> > However, I recently discovered two new fsmap problems...What follows is a
> > brief description of them:
> > 
> > Patch 1: In this scenario, fsmap lost one block count. The root cause is
> > that during the calculation of highkey, the calculation of start_block is
> > missing an increment by one, which leads to the last query missing one
> > This problem is resolved by adding a sentinel node.
> > 
> > Patch 2: In this scenario, the fsmap query for realtime deivce may display
> > extra intervals. This is due to an extra increase in "end_rtb". The issue
> > is resolved by adjusting the relevant calculations. And this patch depends
> > on the previous patch that introduced "info->end_daddr".
> > 
> > [1] https://lore.kernel.org/all/20240819005320.304211-1-wozizhi@huawei.com/
> > [2] https://lore.kernel.org/all/172437083728.56860.10056307551249098606.stgit@frogsfrogsfrogs/
> > 
> > Zizhi Wo (2):
> >    xfs: Fix missing block calculations in xfs datadev fsmap
> >    xfs: Fix incorrect parameter calculation in rt fsmap
> > 
> >   fs/xfs/libxfs/xfs_rtbitmap.c |  4 +---
> >   fs/xfs/xfs_fsmap.c           | 39 +++++++++++++++++++++++++++++++-----
> >   2 files changed, 35 insertions(+), 8 deletions(-)
> > 
> 

  reply	other threads:[~2024-09-02 19:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  3:10 [PATCH 0/2] Some boundary error bugfix related to XFS fsmap Zizhi Wo
2024-08-26  3:10 ` [PATCH 1/2] xfs: Fix missing block calculations in xfs datadev fsmap Zizhi Wo
2024-11-07 23:43   ` Darrick J. Wong
2024-11-08  2:29     ` Zizhi Wo
2024-11-08 17:30       ` Darrick J. Wong
2024-11-09  2:34         ` Zizhi Wo
2024-08-26  3:10 ` [PATCH 2/2] xfs: Fix incorrect parameter calculation in rt fsmap Zizhi Wo
2024-11-07 23:51   ` Darrick J. Wong
2024-08-29 11:24 ` [PATCH 0/2] Some boundary error bugfix related to XFS fsmap Zizhi Wo
2024-09-02 19:08   ` Darrick J. Wong [this message]
2024-09-03  9:18     ` Zizhi Wo
2024-10-09 13:01     ` Zizhi Wo
2024-11-07  9:21       ` Zizhi Wo
2024-11-07 23:51         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240902190828.GA6224@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=chandan.babu@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=wozizhi@huawei.com \
    --cc=yangerkun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox