public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chandan Babu R <chandanbabu@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <djwong@kernel.org>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/6] xfs: merge xfs_attr_leaf_try_add into xfs_attr_leaf_addname
Date: Tue, 3 Sep 2024 06:26:51 +0200	[thread overview]
Message-ID: <20240903042651.GA30523@lst.de> (raw)
In-Reply-To: <87v7zemua2.fsf@debian-BULLSEYE-live-builder-AMD64>

On Mon, Sep 02, 2024 at 12:08:41PM +0530, Chandan Babu R wrote:
> On Sat, Aug 24, 2024 at 05:40:07 AM +0200, Christoph Hellwig wrote:
> > xfs_attr_leaf_try_add is only called by xfs_attr_leaf_addname, and
> > merging the two will simplify a following error handling fix.
> >
> > To facilitate this move the remote block state save/restore helpers up in
> > the file so that they don't need forward declarations now.
> >
> 
> Hi,
> 
> This patch causes generic/449 to execute indefinitely when using the following
> fstest configuration,

FYI, the culprit actually was the following patch in the series, but
I've reproduced and fixed it yesterday and am about to send a fixed
up series.


  reply	other threads:[~2024-09-03  4:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-24  3:40 fix a DEBUG-only assert failure in xfs/538 v2 Christoph Hellwig
2024-08-24  3:40 ` [PATCH 1/6] xfs: merge xfs_attr_leaf_try_add into xfs_attr_leaf_addname Christoph Hellwig
2024-09-02  6:38   ` Chandan Babu R
2024-09-03  4:26     ` Christoph Hellwig [this message]
2024-08-24  3:40 ` [PATCH 2/6] xfs: return bool from xfs_attr3_leaf_add Christoph Hellwig
2024-08-24  3:40 ` [PATCH 3/6] xfs: distinguish extra split from real ENOSPC from xfs_attr3_leaf_split Christoph Hellwig
2024-08-24  3:40 ` [PATCH 4/6] xfs: fold xfs_bmap_alloc_userdata into xfs_bmapi_allocate Christoph Hellwig
2024-08-24  3:40 ` [PATCH 5/6] xfs: call xfs_bmap_exact_minlen_extent_alloc from xfs_bmap_btalloc Christoph Hellwig
2024-08-24  3:40 ` [PATCH 6/6] xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc Christoph Hellwig
2024-08-27  8:39   ` Chandan Babu R
2024-08-27 22:03 ` fix a DEBUG-only assert failure in xfs/538 v2 Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2024-08-20 17:04 fix a DEBUG-only assert failure in xfs/538 Christoph Hellwig
2024-08-20 17:04 ` [PATCH 1/6] xfs: merge xfs_attr_leaf_try_add into xfs_attr_leaf_addname Christoph Hellwig
2024-08-21 15:52   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903042651.GA30523@lst.de \
    --to=hch@lst.de \
    --cc=chandanbabu@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox