From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Chandan Babu R <chandan.babu@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: don't use __GFP_RETRY_MAYFAIL
Date: Tue, 17 Sep 2024 12:00:47 -0700 [thread overview]
Message-ID: <20240917190047.GM182194@frogsfrogsfrogs> (raw)
In-Reply-To: <20240910042855.3480387-5-hch@lst.de>
On Tue, Sep 10, 2024 at 07:28:47AM +0300, Christoph Hellwig wrote:
> __GFP_RETRY_MAYFAIL increases the likelyhood of allocations to fail,
> which isn't really helpful during log recovery. Remove the flag and
> stick to the default GFP_KERNEL policies.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Sounds fine to me
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_ag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 3f695100d7ab58..f6c666a87dd393 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -289,7 +289,7 @@ xfs_initialize_perag(
> return 0;
>
> for (index = old_agcount; index < agcount; index++) {
> - pag = kzalloc(sizeof(*pag), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
> + pag = kzalloc(sizeof(*pag), GFP_KERNEL);
> if (!pag) {
> error = -ENOMEM;
> goto out_unwind_new_pags;
> --
> 2.45.2
>
>
prev parent reply other threads:[~2024-09-17 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 4:28 fix recovery of extfree items just after a growfs Christoph Hellwig
2024-09-10 4:28 ` [PATCH 1/4] xfs: pass the exact range to initialize to xfs_initialize_perag Christoph Hellwig
2024-09-17 18:50 ` Darrick J. Wong
2024-09-18 6:15 ` Christoph Hellwig
2024-09-10 4:28 ` [PATCH 2/4] xfs: merge the perag freeing helpers Christoph Hellwig
2024-09-17 18:55 ` Darrick J. Wong
2024-09-18 6:15 ` Christoph Hellwig
2024-09-10 4:28 ` [PATCH 3/4] xfs: create perag structures as soon as possible during log recovery Christoph Hellwig
2024-09-16 1:28 ` Dave Chinner
2024-09-18 6:11 ` Christoph Hellwig
2024-09-19 1:09 ` Dave Chinner
2024-09-19 7:46 ` Christoph Hellwig
2024-09-19 21:50 ` Dave Chinner
2024-09-10 4:28 ` [PATCH 4/4] xfs: don't use __GFP_RETRY_MAYFAIL Christoph Hellwig
2024-09-17 19:00 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917190047.GM182194@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox