From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08492F28; Thu, 19 Sep 2024 23:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726789308; cv=none; b=kW66ksIpjOpUxf9vq1GBYQVtASHB2NHhnjuFFybfGJI5xc+j7h7M+bSicXsYKd2X51oKyUXSPFGSHoVzHCPHzJeu1/g1VRmNCnnyBXZP/gRr9doMP9vSlUNm3U4Jd+DcCO8zA90vYD6pkTebA4TyGrLDRLSEj7gaOC4UG5DYAL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726789308; c=relaxed/simple; bh=vz/QIZDB47L93JWTsoRjr27Dol6C67qi2DrzrtiaLPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dCUxCaiwPOGbXYtcpScEl/4iEt765hAQn6Mz7Z3NLkecwCpsD20KbG1akbs5/ZTxzfMa29c1or3qSkOcdi9e2Lr4/0Eqf1ElmtJBMFlXCNygij5OjjfeyWhVu9AU+fUsFdqAtCiYwqVz9E7U4mVr60SR9NXt0w3k18SGsy7diN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BjEPNxsU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BjEPNxsU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 399D2C4CEC5; Thu, 19 Sep 2024 23:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726789308; bh=vz/QIZDB47L93JWTsoRjr27Dol6C67qi2DrzrtiaLPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BjEPNxsU2EAHVeelpw9uycRMHeln01mG9DBbcO7HUYJVYDsHHZjh83g8LZMrwBd93 bH+4FhJ4HFvRA2sKid7WgTQydB4t4y6JCxE+NM6BQcImT1/3x4ZJpHDQFuyJ15Q6tB xAuvrIXgNYn5Ur3aawTuu3quwbduJgGzY+dFMwcAP1eri9+zqYxeUSe7Db3/ByrXjS eeogUXERW2ouBk5o7dRINrJISxdhZBCbTDckbLIW1ha2owy8IuTpfy7edJwtVpJHdH qM1AfpMNbRxF43f9j27z2n9cZUNfLgr8rZk4O5YeML4r702pPdCdu7sns/467N30gH ZkqZIevq/r86g== Date: Thu, 19 Sep 2024 16:41:46 -0700 From: "Darrick J. Wong" To: Peter Zijlstra Cc: Thomas Gleixner , Chandan Babu R , Matthew Wilcox , xfs , linux-fsdevel , linux-kernel , x86@kernel.org Subject: Re: Are jump labels broken on 6.11-rc1? Message-ID: <20240919234146.GH182177@frogsfrogsfrogs> References: <20240806094413.GS37996@noisy.programming.kicks-ass.net> <20240806103808.GT37996@noisy.programming.kicks-ass.net> <875xsc4ehr.ffs@tglx> <20240807143407.GC31338@noisy.programming.kicks-ass.net> <87wmks2xhi.ffs@tglx> <20240807150503.GF6051@frogsfrogsfrogs> <20240827033506.GH865349@frogsfrogsfrogs> <20240905081241.GM4723@noisy.programming.kicks-ass.net> <20240905091605.GE4928@noisy.programming.kicks-ass.net> <20240916160801.GA182194@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916160801.GA182194@frogsfrogsfrogs> On Mon, Sep 16, 2024 at 09:08:01AM -0700, Darrick J. Wong wrote: > On Thu, Sep 05, 2024 at 11:16:05AM +0200, Peter Zijlstra wrote: > > On Thu, Sep 05, 2024 at 10:12:41AM +0200, Peter Zijlstra wrote: > > > On Mon, Aug 26, 2024 at 08:35:06PM -0700, Darrick J. Wong wrote: > > > > > > [33965.988873] ------------[ cut here ]------------ > > > > [33966.013870] WARNING: CPU: 1 PID: 8992 at kernel/jump_label.c:295 __static_key_slow_dec_cpuslocked.part.0+0xb0/0xc0 > > > > > > [33966.040184] pc : __static_key_slow_dec_cpuslocked.part.0+0xb0/0xc0 > > > > [33966.042845] lr : __static_key_slow_dec_cpuslocked.part.0+0x48/0xc0 > > > > > > [33966.072840] Call trace: > > > > [33966.073838] __static_key_slow_dec_cpuslocked.part.0+0xb0/0xc0 > > > > [33966.076105] static_key_slow_dec+0x48/0x88 > > > > > > This corresponds to the: > > > > > > > > WARN_ON_ONCE(!static_key_slow_try_dec(key)); > > > > > > But but but,... my patch killed that function. So are you sure it is > > > applied ?! > > > > > > Because this sounds like exactly that issue again. > > > > > > Anyway, it appears I had totally forgotten about this issue again due to > > > holidays, sorry. Let me stare hard at Thomas' patch and make a 'pretty' > > > one that does boot. > > > > I've taken tglx's version with a small change (added comment) and boot > > tested it and queued it here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/urgent > > > > Could you please double check on both x86_64 and arm64? > > Will send this out on the test farm tonight, thanks for the patch. > > > If green by with the build robots and your own testing I'll push this > > into tip/locking/urgent to be sent to Linus on Sunday. Hopefully finally > > resolving this issue. > > Sorry I didn't get to this earlier; I've been on vacation since the end > of August. Now to get to the ~1300 fsdevel emails... ;) After 3.5 days of continuous pounding on the jump labels I haven't seen any complaints from the kernel, so consider commit 6b01e5a8c11611 ("jump_label: Fix static_key_slow_dec() yet again") Tested-by: Darrick J. Wong Thanks for your help! --D > --D >