Re: [PATCH 2/2] xfsprogs: update gitignore

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Sep 27, 2024 at 03:41:43PM +0200, Andrey Albershteyn wrote:
> Building xfsprogs seems to produce many build artifacts which are
> not tracked by git. Ignore them.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
> ---
>  .gitignore | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index fd131b6fde52..26a7339add42 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -33,6 +33,7 @@
>  /config.status
>  /config.sub
>  /configure
> +/configure~
>  
>  # libtool
>  /libtool
> @@ -73,9 +74,20 @@ cscope.*
>  /scrub/xfs_scrub_all
>  /scrub/xfs_scrub_all.cron
>  /scrub/xfs_scrub_all.service
> +/scrub/xfs_scrub_all_fail.service
> +/scrub/xfs_scrub_fail
>  /scrub/xfs_scrub_fail@.service
> +/scrub/xfs_scrub_media@.service
> +/scrub/xfs_scrub_media_fail@.service

/me wonders if *.service/*.cron should be a wildcard to match
scrub/Makefile's LDIRT definition.

>  # generated crc files
> +/libxfs/crc32selftest
> +/libxfs/crc32table.h
> +/libxfs/gen_crc32table

This all moved to libfrog in 2018, how is it still building in libxfs?

>  /libfrog/crc32selftest
>  /libfrog/crc32table.h
>  /libfrog/gen_crc32table
> +
> +# docs
> +/man/man8/mkfs.xfs.8
> +/man/man8/xfs_scrub_all.8

Looks good.

--D

> -- 
> 2.44.1
> 
>