* [PATCH] xfs: fix a typo
@ 2024-10-02 21:19 Andrew Kreimer
2024-10-02 21:28 ` Darrick J. Wong
2024-10-03 5:59 ` Dan Carpenter
0 siblings, 2 replies; 7+ messages in thread
From: Andrew Kreimer @ 2024-10-02 21:19 UTC (permalink / raw)
To: Chandan Babu R, Darrick J . Wong
Cc: linux-xfs, linux-kernel, kernel-janitors, Andrew Kreimer
Fix a typo in comments.
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
fs/xfs/xfs_log_recover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index ec766b4bc853..a13bf53fea49 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1849,7 +1849,7 @@ xlog_find_item_ops(
* from the transaction. However, we can't do that until after we've
* replayed all the other items because they may be dependent on the
* cancelled buffer and replaying the cancelled buffer can remove it
- * form the cancelled buffer table. Hence they have tobe done last.
+ * form the cancelled buffer table. Hence they have to be done last.
*
* 3. Inode allocation buffers must be replayed before inode items that
* read the buffer and replay changes into it. For filesystems using the
--
2.39.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: fix a typo
2024-10-02 21:19 [PATCH] xfs: fix a typo Andrew Kreimer
@ 2024-10-02 21:28 ` Darrick J. Wong
2024-10-03 5:59 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Darrick J. Wong @ 2024-10-02 21:28 UTC (permalink / raw)
To: Andrew Kreimer; +Cc: Chandan Babu R, linux-xfs, linux-kernel, kernel-janitors
On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_log_recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index ec766b4bc853..a13bf53fea49 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1849,7 +1849,7 @@ xlog_find_item_ops(
> * from the transaction. However, we can't do that until after we've
> * replayed all the other items because they may be dependent on the
> * cancelled buffer and replaying the cancelled buffer can remove it
> - * form the cancelled buffer table. Hence they have tobe done last.
> + * form the cancelled buffer table. Hence they have to be done last.
> *
> * 3. Inode allocation buffers must be replayed before inode items that
> * read the buffer and replay changes into it. For filesystems using the
> --
> 2.39.5
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: fix a typo
2024-10-02 21:19 [PATCH] xfs: fix a typo Andrew Kreimer
2024-10-02 21:28 ` Darrick J. Wong
@ 2024-10-03 5:59 ` Dan Carpenter
2024-10-03 8:30 ` Andrew Kreimer
1 sibling, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2024-10-03 5:59 UTC (permalink / raw)
To: Andrew Kreimer
Cc: Chandan Babu R, Darrick J . Wong, linux-xfs, linux-kernel,
kernel-janitors
On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
>
Could you explain what the typos are in the commit message so that we can spot
it more easily? It saves a little review time.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: fix a typo
2024-10-03 5:59 ` Dan Carpenter
@ 2024-10-03 8:30 ` Andrew Kreimer
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Kreimer @ 2024-10-03 8:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chandan Babu R, Darrick J . Wong, linux-xfs, linux-kernel,
kernel-janitors
On Thu, Oct 03, 2024 at 08:59:42AM +0300, Dan Carpenter wrote:
> On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> > Fix a typo in comments.
> >
>
> Could you explain what the typos are in the commit message so that we can spot
> it more easily? It saves a little review time.
Noted, thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] xfs: Fix a typo
@ 2021-03-22 6:39 Bhaskar Chowdhury
2021-03-22 10:29 ` Pavel Reichl
2021-03-22 18:48 ` Randy Dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-22 6:39 UTC (permalink / raw)
To: djwong, linux-xfs, linux-kernel; +Cc: rdunlap, Bhaskar Chowdhury
s/strutures/structures/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/xfs/xfs_aops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index b4186d666157..1cc7c36d98e9 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -158,7 +158,7 @@ xfs_end_ioend(
nofs_flag = memalloc_nofs_save();
/*
- * Just clean up the in-memory strutures if the fs has been shut down.
+ * Just clean up the in-memory structures if the fs has been shut down.
*/
if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
error = -EIO;
--
2.31.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] xfs: Fix a typo
2021-03-22 6:39 [PATCH] xfs: Fix " Bhaskar Chowdhury
@ 2021-03-22 10:29 ` Pavel Reichl
2021-03-22 18:48 ` Randy Dunlap
1 sibling, 0 replies; 7+ messages in thread
From: Pavel Reichl @ 2021-03-22 10:29 UTC (permalink / raw)
To: Bhaskar Chowdhury, linux-xfs
On 3/22/21 7:39 AM, Bhaskar Chowdhury wrote:
>
> s/strutures/structures/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> fs/xfs/xfs_aops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index b4186d666157..1cc7c36d98e9 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -158,7 +158,7 @@ xfs_end_ioend(
> nofs_flag = memalloc_nofs_save();
>
> /*
> - * Just clean up the in-memory strutures if the fs has been shut down.
> + * Just clean up the in-memory structures if the fs has been shut down.
> */
> if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> error = -EIO;
> --
> 2.31.0
>
Hi,
LGTM,
Reviewed-by: Pavel Reichl <preichl@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] xfs: Fix a typo
2021-03-22 6:39 [PATCH] xfs: Fix " Bhaskar Chowdhury
2021-03-22 10:29 ` Pavel Reichl
@ 2021-03-22 18:48 ` Randy Dunlap
1 sibling, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2021-03-22 18:48 UTC (permalink / raw)
To: Bhaskar Chowdhury, djwong, linux-xfs, linux-kernel
On 3/21/21 11:39 PM, Bhaskar Chowdhury wrote:
>
> s/strutures/structures/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> fs/xfs/xfs_aops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index b4186d666157..1cc7c36d98e9 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -158,7 +158,7 @@ xfs_end_ioend(
> nofs_flag = memalloc_nofs_save();
>
> /*
> - * Just clean up the in-memory strutures if the fs has been shut down.
> + * Just clean up the in-memory structures if the fs has been shut down.
> */
> if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> error = -EIO;
> --
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-03 8:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 21:19 [PATCH] xfs: fix a typo Andrew Kreimer
2024-10-02 21:28 ` Darrick J. Wong
2024-10-03 5:59 ` Dan Carpenter
2024-10-03 8:30 ` Andrew Kreimer
-- strict thread matches above, loose matches on Subject: below --
2021-03-22 6:39 [PATCH] xfs: Fix " Bhaskar Chowdhury
2021-03-22 10:29 ` Pavel Reichl
2021-03-22 18:48 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).