From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: linux-xfs@vger.kernel.org, aalbersh@kernel.org
Subject: Re: [PATCH v3 2/2] xfsprogs: update gitignore
Date: Wed, 2 Oct 2024 15:54:55 -0700 [thread overview]
Message-ID: <20241002225455.GK21853@frogsfrogsfrogs> (raw)
In-Reply-To: <20241002103624.1323492-3-aalbersh@redhat.com>
On Wed, Oct 02, 2024 at 12:36:24PM +0200, Andrey Albershteyn wrote:
> Building xfsprogs seems to produce many build artifacts which are
> not tracked by git. Ignore them.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
> ---
>
> Notes:
> Replace ./configure~ with wildcard ./*~ to remove all backup files
> which autoconf (or any other tool) can create
Seems fine to me...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> .gitignore | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index fd131b6fde52..756867124a02 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -33,6 +33,7 @@
> /config.status
> /config.sub
> /configure
> +/*~
>
> # libtool
> /libtool
> @@ -69,13 +70,16 @@ cscope.*
> /rtcp/xfs_rtcp
> /spaceman/xfs_spaceman
> /scrub/xfs_scrub
> -/scrub/xfs_scrub@.service
> /scrub/xfs_scrub_all
> -/scrub/xfs_scrub_all.cron
> -/scrub/xfs_scrub_all.service
> -/scrub/xfs_scrub_fail@.service
> +/scrub/xfs_scrub_fail
> +/scrub/*.cron
> +/scrub/*.service
>
> # generated crc files
> /libfrog/crc32selftest
> /libfrog/crc32table.h
> /libfrog/gen_crc32table
> +
> +# docs
> +/man/man8/mkfs.xfs.8
> +/man/man8/xfs_scrub_all.8
> --
> 2.44.1
>
>
prev parent reply other threads:[~2024-10-02 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 10:36 [PATCH v3 0/2] Minor fixes for xfsprogs Andrey Albershteyn
2024-10-02 10:36 ` [PATCH v3 1/2] xfsprogs: fix permissions on files installed by libtoolize Andrey Albershteyn
2024-10-02 22:54 ` Darrick J. Wong
2024-10-02 10:36 ` [PATCH v3 2/2] xfsprogs: update gitignore Andrey Albershteyn
2024-10-02 22:54 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002225455.GK21853@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=aalbersh@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).