Re: fix stale delalloc punching for COW I/O v4

Darrick J. Wong
2024-10-07T06:28:42Z

On Mon, Oct 07, 2024 at 07:41:01AM +0200, Christoph Hellwig wrote:
> On Sat, Oct 05, 2024 at 08:53:12AM -0700, Darrick J. Wong wrote:
> > Hmmm so I tried applying this series, but now I get this splat:
> >
> > [ 217.170122] run fstests xfs/574 at 2024-10-04 16:36:30
>
> I don't. What xfstests tree is this with?

Hum. My latest djwong-wtf xfstests tree. You might have to have the
new funshare patch I sent for fsstress, though iirc that's already in my
-wtf branch.

> > I think this series needs to assert that the invalidatelock is held
> > (instead of taking it) for the IOMAP_UNSHARE case too, since UNSHARE is
> > called from fallocate, which has already taken the MMAPLOCK.
>
> Yes. I'll look into fixing it, but so far I haven't managed to
> reproduce the actual splat.

<nod>

--D