From: Christoph Hellwig <hch@lst.de>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: linux-xfs@vger.kernel.org, Ritesh Harjani <ritesh.list@gmail.com>,
linux-kernel@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
dchinner@redhat.com, Chandan Babu R <chandan.babu@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] xfs: Check for deallayed allocations before setting extsize
Date: Thu, 10 Oct 2024 08:50:21 +0200 [thread overview]
Message-ID: <20241010065021.GA6611@lst.de> (raw)
In-Reply-To: <20241010063617.563365-1-ojaswin@linux.ibm.com>
s/deallayed/delayed/
>
> +static inline bool xfs_inode_has_data(struct xfs_inode *ip)
> +{
> + return (ip->i_df.if_nextents > 0 || ip->i_delayed_blks > 0);
Nit: no need for the braces.
> + if (S_ISREG(VFS_I(ip)->i_mode) &&
> + xfs_inode_has_data(ip) &&
This can now be condensed to:
if (S_ISREG(VFS_I(ip)->i_mode) && xfs_inode_has_data(ip) &&
Otherwise this still looks good to me.
next prev parent reply other threads:[~2024-10-10 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 6:36 [PATCH v2] xfs: Check for deallayed allocations before setting extsize Ojaswin Mujoo
2024-10-10 6:50 ` Christoph Hellwig [this message]
2024-10-10 8:56 ` Ojaswin Mujoo
2024-10-10 18:34 ` Darrick J. Wong
2024-10-11 8:51 ` Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010065021.GA6611@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox