xfsprogs build: missing hard dependency?

xfsprogs build: missing hard dependency?

[Páder Rezső]

Hello,


I tried to compile now the xfsprogs 6.10.1 release, but it failed:


/bin/ld: fsproperties.o: in function `fileio_to_fsprops_handle':
/var/uhubuild/work/compile/io/fsproperties.c:63:(.text+0x155): undefined reference to `fsprops_open_handle'
/bin/ld: fsproperties.o: in function `print_fsprop':
/var/uhubuild/work/compile/io/fsproperties.c:99:(.text+0x26d): undefined reference to `fsprops_get'
/bin/ld: fsproperties.o: in function `listfsprops_f':
/var/uhubuild/work/compile/io/fsproperties.c:133:(.text+0x380): undefined reference to `fsprops_walk_names'
/bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:139:(.text+0x390): undefined reference to `fsprops_free_handle'
/bin/ld: fsproperties.o: in function `removefsprops_f':
/var/uhubuild/work/compile/io/fsproperties.c:331:(.text+0x48f): undefined reference to `fsprops_remove'
/bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:339:(.text+0x4a8): undefined reference to `fsprops_free_handle'
/bin/ld: fsproperties.o: in function `getfsprops_f':
/var/uhubuild/work/compile/io/fsproperties.c:189:(.text+0x5b6): undefined reference to `fsprops_get'
/bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:199:(.text+0x5e3): undefined reference to `fsprops_free_handle'
/bin/ld: fsproperties.o: in function `setfsprops_f':
/var/uhubuild/work/compile/io/fsproperties.c:271:(.text+0x6d4): undefined reference to `fsprops_set'
/bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:284:(.text+0x74f): undefined reference to `fsprops_free_handle'
collect2: error: ld returned 1 exit status

These functions are defined in libfrog/fsprops.h, but this is included
only if the libattr is exists.

After adding libattr to build dependencies, the build is succesful, so
I think, the libattr always needed for this source.

-- 
Bestr regards.

Rezso

Re: xfsprogs build: missing hard dependency?

[Darrick J. Wong]

On Fri, Oct 11, 2024 at 02:15:22PM +0200, Páder Rezső wrote:
> Hello,
> 
> 
> I tried to compile now the xfsprogs 6.10.1 release, but it failed:
> 
> 
> /bin/ld: fsproperties.o: in function `fileio_to_fsprops_handle':
> /var/uhubuild/work/compile/io/fsproperties.c:63:(.text+0x155): undefined reference to `fsprops_open_handle'
> /bin/ld: fsproperties.o: in function `print_fsprop':
> /var/uhubuild/work/compile/io/fsproperties.c:99:(.text+0x26d): undefined reference to `fsprops_get'
> /bin/ld: fsproperties.o: in function `listfsprops_f':
> /var/uhubuild/work/compile/io/fsproperties.c:133:(.text+0x380): undefined reference to `fsprops_walk_names'
> /bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:139:(.text+0x390): undefined reference to `fsprops_free_handle'
> /bin/ld: fsproperties.o: in function `removefsprops_f':
> /var/uhubuild/work/compile/io/fsproperties.c:331:(.text+0x48f): undefined reference to `fsprops_remove'
> /bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:339:(.text+0x4a8): undefined reference to `fsprops_free_handle'
> /bin/ld: fsproperties.o: in function `getfsprops_f':
> /var/uhubuild/work/compile/io/fsproperties.c:189:(.text+0x5b6): undefined reference to `fsprops_get'
> /bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:199:(.text+0x5e3): undefined reference to `fsprops_free_handle'
> /bin/ld: fsproperties.o: in function `setfsprops_f':
> /var/uhubuild/work/compile/io/fsproperties.c:271:(.text+0x6d4): undefined reference to `fsprops_set'
> /bin/ld: /var/uhubuild/work/compile/io/fsproperties.c:284:(.text+0x74f): undefined reference to `fsprops_free_handle'
> collect2: error: ld returned 1 exit status
> 
> These functions are defined in libfrog/fsprops.h, but this is included
> only if the libattr is exists.
> 
> After adding libattr to build dependencies, the build is succesful, so
> I think, the libattr always needed for this source.

I already removed the libattr dependencies:
https://lore.kernel.org/linux-xfs/172783101339.4035924.6880384393728950920.stgit@frogsfrogsfrogs/

(xfsprogs 6.11 will probably be out soonish...)

--D

> -- 
> Bestr regards.
> 
> Rezso
>