Re: [PATCH 2/2] xfs/122: add tests for commitrange structures

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 11, 2024 at 02:28:58PM +0800, Zorro Lang wrote:
> On Wed, Oct 02, 2024 at 03:47:00PM -0700, Darrick J. Wong wrote:
> > On Tue, Oct 01, 2024 at 10:45:50PM -0700, Christoph Hellwig wrote:
> > > On Tue, Oct 01, 2024 at 09:49:27AM -0700, Darrick J. Wong wrote:
> > > > From: Darrick J. Wong <djwong@kernel.org>
> > > > 
> > > > Update this test to check the ioctl structure for XFS_IOC_COMMIT_RANGE.
> > > 
> > > Meh.  Can we please not add more to xfs/122, as that's alway just
> > > a pain?  We can just static_assert the size in xfsprogs (or the
> > > xfstests code using it) instead of this mess.
> > 
> > Oh right, we had a plan to autotranslate the xfs/122 stuff to
> > xfs_ondisk.h didn't we... I'll put that back on my list.
> 
> Hi Darrick,
> 
> Do you want to have this patch at first, or just wait for your
> next version which does the "autotranslate"?

Let's drop this for now, machine-converting xfs/122 to xfs_ondisk.h
wasn't as hard as I thought it might be.  Would you be ok with merging
the fiexchange.h patch and the fsstress funshare patch this week?

--D

> Thanks,
> Zorro
> 
> > 
> > --D
> > 
> 
>