From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: new EOF fragmentation tests
Date: Tue, 15 Oct 2024 01:46:50 +0800 [thread overview]
Message-ID: <20241014174650.wms62e3ogzilcnn5@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <20241014152428.GQ21840@frogsfrogsfrogs>
On Mon, Oct 14, 2024 at 08:24:28AM -0700, Darrick J. Wong wrote:
> On Mon, Oct 14, 2024 at 08:07:25AM +0200, Christoph Hellwig wrote:
> > On Mon, Oct 14, 2024 at 01:49:36AM +0800, Zorro Lang wrote:
> > > Thanks for reworking this patch, it's been merged into fstests, named
> > > xfs/629~632. But now these 4 cases always fail on upstream xfs, e.g
> > > (diff output) [1][2][3][4]. Could you help to take a look at the
> > > failure which Darick metioned above too :)
> >
> > What do you mean with upstream xfs? Any kernel before the eofblocks
> > fixes will obviously fail. Always_cow will also always fail and I'll
> > send a patch for that. Any other configuration you've seen?
>
> fsdax, any config with an extent size hint set, and any time
> sb_rextsize > 1 fsblock.
Even with dax=never, it's still reproducible. There's not any special config
about the extent size hint. The mkfs.xfs option is:
"-b size=4096 -m crc=1,finobt=1,rmapbt=0,reflink=0,inobtcount=1,bigtime=1"
The mkfs output is:
meta-data=/dev/pmem0 isize=512 agcount=4, agsize=655360 blks
= sectsz=4096 attr=2, projid32bit=1
= crc=1 finobt=1, sparse=1, rmapbt=0
= reflink=0 bigtime=1 inobtcount=1 nrext64=1
= exchange=0
data = bsize=4096 blocks=2621440, imaxpct=25
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0, ftype=1, parent=0
log =internal log bsize=4096 blocks=300954, version=2
= sectsz=4096 sunit=1 blks, lazy-count=1
realtime =none extsz=4096 blocks=0, rtextents=0
From the output we can see the sector size is 4096.
The mount option is "-o dax=always/inode/never", no more, without external
log device, no rtdev.
Thanks,
Zorro
>
> --D
>
next prev parent reply other threads:[~2024-10-14 17:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 8:45 xfs post-EOF block freeing fixes v2 Christoph Hellwig
2024-09-24 8:45 ` [PATCH] xfs: new EOF fragmentation tests Christoph Hellwig
2024-09-24 15:03 ` Darrick J. Wong
2024-09-25 11:15 ` Zorro Lang
2024-09-26 12:31 ` Zorro Lang
2024-10-01 14:59 ` Darrick J. Wong
2024-10-02 13:38 ` Zorro Lang
2024-10-02 14:35 ` Brian Foster
2024-10-02 14:57 ` Darrick J. Wong
2024-10-02 15:56 ` Brian Foster
2024-10-02 20:04 ` Darrick J. Wong
2024-10-13 17:49 ` Zorro Lang
2024-10-14 6:07 ` Christoph Hellwig
2024-10-14 14:14 ` Zorro Lang
2024-10-14 15:24 ` Darrick J. Wong
2024-10-14 17:46 ` Zorro Lang [this message]
2024-10-15 3:39 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-06-23 5:38 xfs post-EOF block freeing fixes Christoph Hellwig
2024-06-23 5:38 ` [PATCH] xfs: new EOF fragmentation tests Christoph Hellwig
2024-06-23 13:03 ` Zorro Lang
2024-06-24 8:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014174650.wms62e3ogzilcnn5@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com \
--to=zlang@redhat.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).