Re: [PATCH 2/6] xfs: advertise realtime quota support in the xqm stat files

Darrick J. Wong
2024-10-15T00:49:52Z

On Mon, Oct 14, 2024 at 01:25:14AM -0700, Christoph Hellwig wrote:
> > +#ifdef CONFIG_XFS_RT
> > + 1
> > +#else
> > + 0
> > +#endif
>
> This should use IS_ENABLED()

Done.

static int xqm_proc_show(struct seq_file *m, void *v)
{
/* maximum; incore; ratio free to inuse; freelist; rtquota */
seq_printf(m, "%d\t%d\t%d\t%u\t%u\n",
0, counter_val(xfsstats.xs_stats, XFSSTAT_END_XQMSTAT),
0, counter_val(xfsstats.xs_stats, XFSSTAT_END_XQMSTAT + 1),
IS_ENABLED(CONFIG_XFS_RT));
return 0;
}

Thanks to your other patch adding IS_ENABLED to xfs_alloc.c that got
merged in -rc3, I had to port that to userspace, so now I actually know
what that macro /really/ does. ;)

--D