Re: [PATCH 15/36] xfs: store rtgroup information with a bmap intent

Christoph Hellwig
2024-10-14T08:04:01Z

The actual intent code looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

but while re-reviewing I noticed a minor thing in the tracing code:

> + __entry->dev = mp->m_super->s_dev;
> + __entry->type = bi->bi_group->xg_type;
> + __entry->agno = bi->bi_group->xg_index;
> + switch (__entry->type) {
> + case XG_TYPE_RTG:
> + /*
> + * Use the 64-bit version of xfs_rtb_to_rgbno because
> + * legacy rt filesystems can have group block numbers
> + * that exceed the size of an xfs_rgblock_t.
> + */
> + __entry->gbno = __xfs_rtb_to_rgbno(mp,
> bi->bi_bmap.br_startblock);
> + break;
> + case XG_TYPE_AG:
> + __entry->gbno = XFS_FSB_TO_AGBNO(mp,
> bi->bi_bmap.br_startblock);
> + break;
> + default:
> + /* should never happen */
> + __entry->gbno = -1ULL;
> + break;

Maybe just make this an

if (type == XG_TYPE_RTG)
__xfs_rtb_to_rgbno()
else
xfs_fsb_to_gbno()

?

> __entry->l_len,
>
>
---end quoted text---