public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
	djwong@kernel.org, hch@lst.de
Subject: Re: [PATCH 0/2] fstests/xfs: a couple growfs log recovery tests
Date: Fri, 18 Oct 2024 07:09:09 +0200	[thread overview]
Message-ID: <20241018050909.GA19831@lst.de> (raw)
In-Reply-To: <20241017163405.173062-1-bfoster@redhat.com>

On Thu, Oct 17, 2024 at 12:34:03PM -0400, Brian Foster wrote:
> I believe you reproduced a problem with your customized realtime variant
> of the initial test. I've not been able to reproduce any test failures
> with patch 2 here, though I have tried to streamline the test a bit to
> reduce unnecessary bits (patch 1 still reproduces the original
> problems). I also don't tend to test much with rt, so it's possible my
> config is off somehow or another. Otherwise I _think_ I've included the
> necessary changes for rt support in the test itself.
> 
> Thoughts? I'd like to figure out what might be going on there before
> this should land..

Darrick mentioned that was just with his rt group patchset, which
make sense as we don't have per-group metadata without that.

Anyway, the series looks good to me, and I think it supersedes my
more targeted hand crafted reproducer.


  parent reply	other threads:[~2024-10-18  5:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 16:34 [PATCH 0/2] fstests/xfs: a couple growfs log recovery tests Brian Foster
2024-10-17 16:34 ` [PATCH 1/2] xfs: online grow vs. log recovery stress test Brian Foster
2024-10-25 17:32   ` Zorro Lang
2024-10-29 14:22     ` Brian Foster
2024-10-17 16:34 ` [PATCH 2/2] xfs: online grow vs. log recovery stress test (realtime version) Brian Foster
2024-10-18  5:09 ` Christoph Hellwig [this message]
2024-10-18 11:29   ` [PATCH 0/2] fstests/xfs: a couple growfs log recovery tests Brian Foster
2024-10-18 21:39     ` Darrick J. Wong
2024-10-21 16:41     ` Darrick J. Wong
2024-10-22  5:52       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018050909.GA19831@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox