From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/4] design: document realtime groups
Date: Thu, 7 Nov 2024 08:33:18 +0100 [thread overview]
Message-ID: <20241107073318.GF4408@lst.de> (raw)
In-Reply-To: <173092059729.2883258.3327326591290447581.stgit@frogsfrogsfrogs>
> --- a/design/XFS_Filesystem_Structure/allocation_groups.asciidoc
> +++ b/design/XFS_Filesystem_Structure/allocation_groups.asciidoc
> @@ -106,6 +106,10 @@ struct xfs_sb
> xfs_lsn_t sb_lsn;
> uuid_t sb_meta_uuid;
> xfs_ino_t sb_metadirino;
> + xfs_rgnumber_t sb_rgcount;
> + xfs_rgblock_t sb_rgextents;
> + uint8_t sb_rgblklog;
> + uint8_t sb_pad[7];
And following on with my ranting about existing bits theme from the
previous review: why are we documenting the in-memory xfs_sb here
and not the on-disk xfs_dsb?
> +| +XFS_SB_FEAT_RO_COMPAT_RTSB+ |
> +Realtime superblock. The first rt extent in rt group zero contains a superblock
> +header that can be used to identify the realtime device. See the section about
> +the xref:Realtime_Group_Superblocks[realtime group superblocks] for more
> +information.
This is actually gone now.
> +*sb_rgcount*::
> +Count of realtime groups in the filesystem, if the
> ++XFS_SB_FEAT_INCOMPAT_RTGROUPS+ feature is enabled.
... will be zero if XFS_SB_FEAT_INCOMPAT_RTGROUPS is set, but no
realtime subvolume exists
?
next prev parent reply other threads:[~2024-11-07 7:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 19:16 [PATCHBOMB 6.13 v5.5] xfs-docs: metadata directories and realtime groups Darrick J. Wong
2024-11-06 19:17 ` [PATCHSET v31.5 1/3] xfs-documentation: last few updates for online fsck Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/2] design: update metadata reconstruction chapter Darrick J. Wong
2024-11-07 7:28 ` Christoph Hellwig
2024-11-06 19:18 ` [PATCH 2/2] design: document filesystem properties Darrick J. Wong
2024-11-07 7:28 ` Christoph Hellwig
2024-11-06 19:17 ` [PATCHSET v5.5 2/3] xfs-documentation: document metadata directories Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/1] design: document the changes required to handle " Darrick J. Wong
2024-11-07 7:29 ` Christoph Hellwig
2024-11-07 15:56 ` Darrick J. Wong
2024-11-06 19:17 ` [PATCHSET v5.5 3/3] xfs-documentation: shard the realtime section Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/4] design: move discussion of realtime volumes to a separate section Darrick J. Wong
2024-11-07 7:30 ` Christoph Hellwig
2024-11-06 19:19 ` [PATCH 2/4] design: document realtime groups Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig [this message]
2024-11-07 15:58 ` Darrick J. Wong
2024-11-06 19:19 ` [PATCH 3/4] design: document metadata directory tree quota changes Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig
2024-11-06 19:19 ` [PATCH 4/4] design: update metadump v2 format to reflect rt dumps Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-11-07 23:25 [PATCHSET v5.6 2/2] xfs-documentation: shard the realtime section Darrick J. Wong
2024-11-07 23:26 ` [PATCH 2/4] design: document realtime groups Darrick J. Wong
2024-11-08 14:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107073318.GF4408@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox