From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: factor out a xfs_rt_check_size helper
Date: Tue, 19 Nov 2024 17:18:58 +0100 [thread overview]
Message-ID: <20241119161858.GA14774@lst.de> (raw)
In-Reply-To: <20241119161543.GW9438@frogsfrogsfrogs>
On Tue, Nov 19, 2024 at 08:15:43AM -0800, Darrick J. Wong wrote:
> > + error = xfs_buf_read_uncached(mp->m_rtdev_targp, daddr,
> > + XFS_FSB_TO_BB(mp, 1), 0, &bp, NULL);
> > + if (error)
> > + xfs_warn(mp, "cannot read last RT device block (%lld)",
> > + last_block);
>
> "cannot read last RT device sector"? Something to hint that the units
> are 512b blocks, not fsblocks? This is certainly better than the old
> message. :)
Sure.
> Also, should there be a similar function to handle the last datadev
> read that mount and growfs perform?
I'll take a look.
next prev parent reply other threads:[~2024-11-19 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 15:49 small fixes for 6.13 Christoph Hellwig
2024-11-19 15:49 ` [PATCH 1/3] xfs: factor out a xfs_rt_check_size helper Christoph Hellwig
2024-11-19 16:15 ` Darrick J. Wong
2024-11-19 16:18 ` Christoph Hellwig [this message]
2024-11-19 15:49 ` [PATCH 2/3] xfs: use the proper conversion helpers in xfs_rt_check_size Christoph Hellwig
2024-11-19 16:21 ` Darrick J. Wong
2024-11-19 16:23 ` Christoph Hellwig
2024-11-19 15:49 ` [PATCH 3/3] xfs: don't call xfs_bmap_same_rtgroup in xfs_bmap_add_extent_hole_delay Christoph Hellwig
2024-11-19 16:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119161858.GA14774@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox