Re: [ANNOUNCE] xfsprogs v6.12.0 released

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Dec 05, 2024 at 11:09:39AM +0100, Jan Palus wrote:
> On 04.12.2024 21:44, Darrick J. Wong wrote:
> > On Wed, Dec 04, 2024 at 10:50:49PM +0100, Jan Palus wrote:
> > > On 03.12.2024 11:10, Andrey Albershteyn wrote:
> > > > Hi folks,
> > > > 
> > > > The xfsprogs repository at:
> > > > 
> > > > 	git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> > > > 
> > > > has just been updated.
> > > > 
> > > > Patches often get missed, so if your outstanding patches are properly reviewed
> > > > on the list and not included in this update, please let me know.
> > > > 
> > > > The for-next branch has also been updated to match the state of master.
> > > > 
> > > > The new head of the master branch is commit:
> > > > 
> > > > 90d6da68ee54e6d4ef99eca4a82cac6036a34b00
> > > > 
> > > > New commits:
> > > > 
> > > > Andrey Albershteyn (1):
> > > >       [90d6da68ee54] xfsprogs: Release v6.12.0
> > > ...
> > > >       [bc37fe78843f] man: document file range commit ioctls
> > > 
> > > Note there is a small issue in this release -- ioctl_xfs_commit_range.2
> > > man page is never installed due to how INSTALL_MAN works:
> > > 
> > > - for man pages that source other page, like ioctl_xfs_start_commit.2,
> > >   it is copied as is with same filename
> > > 
> > > - for mans with .SH NAME section, like ioctl_xfs_commit_range.2, it will
> > >   use first symbol that follows this section both for source and
> > >   destination filename, which in case of ioctl_xfs_commit_range.2 is
> > >   ioctl_xfs_start_commit
> > > 
> > > Effectively ioctl_xfs_start_commit.2 is copied twice and is broken since
> > > it points to non-existent man page. Swapping symbols in .SH NAME section
> > > is one workaround:
> > > 
> > > @@ -22,8 +22,8 @@
> > >  .\" %%%LICENSE_END
> > >  .TH IOCTL-XFS-COMMIT-RANGE 2  2024-02-18 "XFS"
> > >  .SH NAME
> > > -ioctl_xfs_start_commit \- prepare to exchange the contents of two files
> > >  ioctl_xfs_commit_range \- conditionally exchange the contents of parts of two files
> > > +ioctl_xfs_start_commit \- prepare to exchange the contents of two files
> > 
> > I had not realized that install_man does that. :(
> > 
> > If you turn this into a formal patch I can RVB it and we can merge it
> > upstream.
> 
> Sent.
> 
> Although I was also contemplating swapping content of
> ioctl_xfs_start_commit.2 and ioctl_xfs_commit_range.2 so
> ioctl_xfs_start_commit.2 contains actual content and
> ioctl_xfs_commit_range.2 includes ioctl_xfs_start_commit.2. It would allow
> to maintain logical order of ioctls however I believe emphasis is on
> ioctl_xfs_commit_range and perhaps its preferred to keep main content in
> ioctl_xfs_commit_range.2

Yeah, all of the publicity materials (ha!) mention commit range, so
that's most likely what people will try to look up.

--D

> > 
> > --D
> > 
> > >  .SH SYNOPSIS
> > >  .br
> > >  .B #include <sys/ioctl.h>
> > > 
>