From: "Darrick J. Wong" <djwong@kernel.org>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Ritesh Harjani <ritesh.list@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrey Albershteyn <aalbersh@kernel.org>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [RFC 3/3] xfs_io: add extsize command support
Date: Wed, 11 Dec 2024 10:18:27 -0800 [thread overview]
Message-ID: <20241211181827.GC6678@frogsfrogsfrogs> (raw)
In-Reply-To: <6448e3adc13eff8b152f7954c838eb9315c91574.1733902742.git.ojaswin@linux.ibm.com>
On Wed, Dec 11, 2024 at 01:24:04PM +0530, Ojaswin Mujoo wrote:
> extsize command is currently only supported with XFS filesystem.
> Lift this restriction now that ext4 is also supporting extsize hints.
>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Seems pretty straightforward to me. Are you planning to add an extsize
option to chattr?
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> io/open.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/open.c b/io/open.c
> index a30dd89a1fd5..2582ff9b862e 100644
> --- a/io/open.c
> +++ b/io/open.c
> @@ -997,7 +997,7 @@ open_init(void)
> extsize_cmd.args = _("[-D | -R] [extsize]");
> extsize_cmd.argmin = 0;
> extsize_cmd.argmax = -1;
> - extsize_cmd.flags = CMD_NOMAP_OK;
> + extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> extsize_cmd.oneline =
> _("get/set preferred extent size (in bytes) for the open file");
> extsize_cmd.help = extsize_help;
> --
> 2.43.5
>
>
next prev parent reply other threads:[~2024-12-11 18:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 7:54 [RFC 0/3] xfs_io: enable extsize and stat -v support for ext4 Ojaswin Mujoo
2024-12-11 7:54 ` [RFC 1/3] include/linux.h: Factor out generic platform_test_fs_fd() helper Ojaswin Mujoo
2024-12-11 18:09 ` Darrick J. Wong
2024-12-12 12:05 ` Ojaswin Mujoo
2024-12-13 5:57 ` Christoph Hellwig
2024-12-13 18:37 ` Ojaswin Mujoo
2024-12-11 7:54 ` [RFC 2/3] xfs_io: Add ext4 support to show FS_IOC_FSGETXATTR details Ojaswin Mujoo
2024-12-11 18:17 ` Darrick J. Wong
2024-12-11 22:33 ` Dave Chinner
2024-12-12 16:19 ` Darrick J. Wong
2024-12-12 20:44 ` Dave Chinner
2024-12-12 21:07 ` Darrick J. Wong
2024-12-13 18:29 ` Ojaswin Mujoo
2024-12-12 12:01 ` Ojaswin Mujoo
2024-12-11 7:54 ` [RFC 3/3] xfs_io: add extsize command support Ojaswin Mujoo
2024-12-11 18:18 ` Darrick J. Wong [this message]
2024-12-12 12:04 ` Ojaswin Mujoo
2024-12-12 16:19 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211181827.GC6678@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox