xfsprogs metadir/rtgroup man page fixups

xfsprogs metadir/rtgroup man page fixups

[Christoph Hellwig]

Hi all,

this series has two little fixes for the metadir/rtgroup xfsprogs
just sent out by Darrick.

[PATCH 1/2] mkfs: small rgcount man page fixup

[Christoph Hellwig]

All the other options that require a value spell that out, do the same
for the rgcount option.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 man/man8/mkfs.xfs.8.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
index 5a4d481061ff..32361cf973fc 100644
--- a/man/man8/mkfs.xfs.8.in
+++ b/man/man8/mkfs.xfs.8.in
@@ -1190,7 +1190,7 @@ or logical volume containing the section.
 This option disables stripe size detection, enforcing a realtime device with no
 stripe geometry.
 .TP
-.BI rgcount=
+.BI rgcount= value
 This is used to specify the number of allocation groups in the realtime
 section.
 The realtime section of the filesystem can be divided into allocation groups to
-- 
2.45.2

[PATCH 2/2] man: document rgextents geom field

[Christoph Hellwig]

Document the new rgextent geom field.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 man/man2/ioctl_xfs_fsgeometry.2 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/man/man2/ioctl_xfs_fsgeometry.2 b/man/man2/ioctl_xfs_fsgeometry.2
index c808ad5b8b91..502054f391e9 100644
--- a/man/man2/ioctl_xfs_fsgeometry.2
+++ b/man/man2/ioctl_xfs_fsgeometry.2
@@ -49,7 +49,8 @@ struct xfs_fsop_geom {
 
 	__u32         sick;
 	__u32         checked;
-	__u64         reserved[17];
+	__u64         rgextents;
+	__u64         reserved[16];
 };
 .fi
 .in
@@ -139,6 +140,9 @@ Please see the section
 .B XFS METADATA HEALTH REPORTING
 for more details.
 .PP
+.I rgextents
+Is the number of RT extents in each rtgroup.
+.PP
 .I reserved
 is set to zero.
 .SH FILESYSTEM FEATURE FLAGS
-- 
2.45.2

Re: [PATCH 1/2] mkfs: small rgcount man page fixup

[Darrick J. Wong]

On Wed, Dec 11, 2024 at 07:05:36PM +0100, Christoph Hellwig wrote:
> All the other options that require a value spell that out, do the same
> for the rgcount option.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Oops, yeah, I forgot that. :(
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  man/man8/mkfs.xfs.8.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index 5a4d481061ff..32361cf973fc 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -1190,7 +1190,7 @@ or logical volume containing the section.
>  This option disables stripe size detection, enforcing a realtime device with no
>  stripe geometry.
>  .TP
> -.BI rgcount=
> +.BI rgcount= value
>  This is used to specify the number of allocation groups in the realtime
>  section.
>  The realtime section of the filesystem can be divided into allocation groups to
> -- 
> 2.45.2
> 
> 

Re: [PATCH 2/2] man: document rgextents geom field

[Darrick J. Wong]

On Wed, Dec 11, 2024 at 07:05:37PM +0100, Christoph Hellwig wrote:
> Document the new rgextent geom field.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  man/man2/ioctl_xfs_fsgeometry.2 | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/man/man2/ioctl_xfs_fsgeometry.2 b/man/man2/ioctl_xfs_fsgeometry.2
> index c808ad5b8b91..502054f391e9 100644
> --- a/man/man2/ioctl_xfs_fsgeometry.2
> +++ b/man/man2/ioctl_xfs_fsgeometry.2
> @@ -49,7 +49,8 @@ struct xfs_fsop_geom {
>  
>  	__u32         sick;
>  	__u32         checked;
> -	__u64         reserved[17];
> +	__u64         rgextents;
> +	__u64         reserved[16];
>  };
>  .fi
>  .in
> @@ -139,6 +140,9 @@ Please see the section
>  .B XFS METADATA HEALTH REPORTING
>  for more details.
>  .PP
> +.I rgextents
> +Is the number of RT extents in each rtgroup.
> +.PP
>  .I reserved
>  is set to zero.
>  .SH FILESYSTEM FEATURE FLAGS
> -- 
> 2.45.2
> 
>