Re: [PATCH 21/41] xfs_repair: preserve the metadirino field when zeroing supers

Darrick J. Wong
2024-12-11T21:10:34Z

On Mon, Dec 09, 2024 at 09:05:04PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 06, 2024 at 03:45:07PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > The metadata directory root inumber is now the last field in the
> > superblock, so extend the zeroing code to know about that.
>
> The commit message matches the code, but the subject seems to directly
> contradict it, so it'll need a little fixup.

Ah, yeah. Let's change it to:

"xfs_repair: preserve the metadirino field when zeroing supers"

> The code changes themselves look good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D