Re: [PATCH 31/41] xfs_repair: update incore metadata state whenever we create new files

Darrick J. Wong
2024-12-11T21:21:01Z

On Mon, Dec 09, 2024 at 09:17:53PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 06, 2024 at 03:47:43PM -0800, Darrick J. Wong wrote:
> > +{
> > + struct ino_tree_node *irec;
> > + int ino_offset;
> > +
> > + irec = find_inode_rec(mp, XFS_INO_TO_AGNO(mp, ino),
> > + XFS_INO_TO_AGINO(mp, ino));
> > + ino_offset = get_inode_offset(mp, ino, irec);
> > + set_inode_is_meta(irec, ino_offset);
>
> Nit: I'd do away with the ino_offset variable here.

<nod> I'll clean this one up similarly too:

static void
mark_ino_metadata(
struct xfs_mount *mp,
xfs_ino_t ino)
{
struct ino_tree_node *irec =
find_inode_rec(mp, XFS_INO_TO_AGNO(mp, ino),
XFS_INO_TO_AGINO(mp, ino));

set_inode_is_meta(irec, get_inode_offset(mp, ino, irec));
}

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thank you!

--D