Re: [PATCH 09/41] xfs_db: disable xfs_check when metadir is enabled

Darrick J. Wong
2024-12-11T19:26:32Z

On Mon, Dec 09, 2024 at 08:55:34PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 06, 2024 at 03:41:59PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > As of July 2024, xfs_repair can detect more types of corruptions than
> > xfs_check does. I don't think it makes sense to maintain the xfs_check
> > code anymore, so let's just turn it off for any filesystem that has
> > metadata directory trees.
>
> Puh, long overdue. Would be great to also have a deprecation schedule
> for it in general..

We stopped shipping xfs_check a decade ago and removed xfs_check from
fstests back in July, so I think we could just remove everything between
check_rootdir() and the final quota_check() in blockget_f.

I guess I could try that and see what happens. Thanks for the reviews
here. :)

--D

> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > +
> > check_rootdir();
> > /*
> > * Check that there are no blocks either
> >
> >
> ---end quoted text---
>