Re: [PATCH 33/43] xfs: support xchk_xref_is_used_rt_space on zoned file systems

Darrick J. Wong
2024-12-17T17:02:57Z

On Sun, Dec 15, 2024 at 07:13:49AM +0100, Christoph Hellwig wrote:
> On Fri, Dec 13, 2024 at 02:49:12PM -0800, Darrick J. Wong wrote:
> > > @@ -272,7 +273,6 @@ xchk_xref_is_used_rt_space(
> > > xfs_extlen_t len)
> > > {
> > > struct xfs_rtgroup *rtg = sc->sr.rtg;
> > > - struct xfs_inode *rbmip = rtg_bitmap(rtg);
>
>
> > > if (is_free)
> > > - xchk_ino_xref_set_corrupt(sc, rbmip->i_ino);
> > > + xchk_ino_xref_set_corrupt(sc, rtg_bitmap(rtg)->i_ino);
> >
> > rbmip is already the return value from rtg_bitmap()
>
> Yes, but it gets removed above. Because it only has a single user,
> and it keeps me from incorrectly referencing it in the zone branch,
> which I did initially and which didn't end up well :)

Oh right, my bad. With the typo in the commit message fixed,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D