Re: [PATCH 14/43] xfs: add a xfs_rtrmap_first_unwritten_rgbno helper

Christoph Hellwig
2024-12-13T05:16:40Z

On Thu, Dec 12, 2024 at 01:48:51PM -0800, Darrick J. Wong wrote:
> > }
> > +
> > +xfs_rgblock_t
> > +xfs_rtrmap_first_unwritten_rgbno(
> > + struct xfs_rtgroup *rtg)
>
> Might want to leave a comment here saying that this only applies to
> zoned realtime devices because they are written start to end, not
> randomly. Otherwise this looks ok to me, having peered into the future
> to see how it got used. :)

Yes. Or rename it and make it return the highest tracked rgbno and
return NULLRGBLOCK, so that all the meaning assigned to that stays
in the caller, which might be less confusing.