Re: [PATCH 32/43] xfs: allow COW forks on zoned file systems in xchk_bmap

Darrick J. Wong
2024-12-13T22:47:21Z

On Wed, Dec 11, 2024 at 09:54:57AM +0100, Christoph Hellwig wrote:
> zoned file systems can have COW forks even without reflinks.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/scrub/bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/scrub/bmap.c b/fs/xfs/scrub/bmap.c
> index 66da7d4d56ba..cfc6f035ecaa 100644
> --- a/fs/xfs/scrub/bmap.c
> +++ b/fs/xfs/scrub/bmap.c
> @@ -1039,7 +1039,7 @@ xchk_bmap(
> switch (whichfork) {
> case XFS_COW_FORK:
> /* No CoW forks on non-reflink filesystems. */
> - if (!xfs_has_reflink(mp)) {
> + if (!xfs_has_reflink(mp) && !xfs_has_zoned(mp)) {

Might want to update the comment

/* No CoW forks filesystem doesn't support out of place writes */

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> xchk_ino_set_corrupt(sc, sc->ip->i_ino);
> return 0;
> }
> --
> 2.45.2
>
>