Re: [PATCH 38/43] xfs: enable the zoned RT device feature

Darrick J. Wong
2024-12-13T22:52:45Z

On Wed, Dec 11, 2024 at 09:55:03AM +0100, Christoph Hellwig wrote:
> Enable the zoned RT device directory feature. With this feature, RT
> groups are written sequentially and always emptied before rewriting
> the blocks. This perfectly maps to zoned devices, but can also be
> used on conventional block devices.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok, though it's a bit odd that this isn't the very end of the
series.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/xfs/libxfs/xfs_format.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index 12979496f30a..fc56de8fe696 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -408,7 +408,8 @@ xfs_sb_has_ro_compat_feature(
> XFS_SB_FEAT_INCOMPAT_NREXT64 | \
> XFS_SB_FEAT_INCOMPAT_EXCHRANGE | \
> XFS_SB_FEAT_INCOMPAT_PARENT | \
> - XFS_SB_FEAT_INCOMPAT_METADIR)
> + XFS_SB_FEAT_INCOMPAT_METADIR | \
> + XFS_SB_FEAT_INCOMPAT_ZONED)
>
> #define XFS_SB_FEAT_INCOMPAT_UNKNOWN ~XFS_SB_FEAT_INCOMPAT_ALL
> static inline bool
> --
> 2.45.2
>
>