Re: [PATCH 18/43] xfs: export zoned geometry via XFS_FSOP_GEOM

Christoph Hellwig
2024-12-13T05:23:52Z

On Thu, Dec 12, 2024 at 02:09:13PM -0800, Darrick J. Wong wrote:
> > + if (xfs_has_zoned(mp)) {
> > + geo->rtstart = XFS_FSB_TO_BB(mp, sbp->sb_rtstart);
>
> Not sure why this is reported in units of 512b, everything else set by
> xfs_fs_geometry is in units of fsblocks.

Because I didn't update it when switching the sb field to FSBs per
a pre-review request :) That being said the sectors actually work
pretty well for the users in xfsprogs, so this will create move code.
But I guess that's worth it to be consistent.