Re: [PATCH 03/43] xfs: add a rtg_blocks helper

Darrick J. Wong
2024-12-12T21:12:26Z

On Wed, Dec 11, 2024 at 09:54:28AM +0100, Christoph Hellwig wrote:
> Shortcut dereferencing the xg_block_count field in the generic group
> structure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good, though I imagine there are a few more places where you could
use this helper?

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/xfs/libxfs/xfs_rtgroup.c | 2 +-
> fs/xfs/libxfs/xfs_rtgroup.h | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rtgroup.c b/fs/xfs/libxfs/xfs_rtgroup.c
> index d84d32f1b48f..97aad8967149 100644
> --- a/fs/xfs/libxfs/xfs_rtgroup.c
> +++ b/fs/xfs/libxfs/xfs_rtgroup.c
> @@ -270,7 +270,7 @@ xfs_rtgroup_get_geometry(
> /* Fill out form. */
> memset(rgeo, 0, sizeof(*rgeo));
> rgeo->rg_number = rtg_rgno(rtg);
> - rgeo->rg_length = rtg_group(rtg)->xg_block_count;
> + rgeo->rg_length = rtg_blocks(rtg);
> xfs_rtgroup_geom_health(rtg, rgeo);
> return 0;
> }
> diff --git a/fs/xfs/libxfs/xfs_rtgroup.h b/fs/xfs/libxfs/xfs_rtgroup.h
> index de4eeb381fc9..0e1d9474ab77 100644
> --- a/fs/xfs/libxfs/xfs_rtgroup.h
> +++ b/fs/xfs/libxfs/xfs_rtgroup.h
> @@ -66,6 +66,11 @@ static inline xfs_rgnumber_t rtg_rgno(const struct xfs_rtgroup *rtg)
> return rtg->rtg_group.xg_gno;
> }
>
> +static inline xfs_rgblock_t rtg_blocks(const struct xfs_rtgroup *rtg)
> +{
> + return rtg->rtg_group.xg_block_count;
> +}
> +
> static inline struct xfs_inode *rtg_bitmap(const struct xfs_rtgroup *rtg)
> {
> return rtg->rtg_inodes[XFS_RTGI_BITMAP];
> --
> 2.45.2
>
>