Re: [PATCH 4/5] xfs: report the correct read/write dio alignment for reflinked inodes

John Garry
2025-01-08T10:13:27Z

On 08/01/2025 08:55, Christoph Hellwig wrote:
> @@ -580,9 +580,24 @@ xfs_report_dioalign(
> struct xfs_buftarg *target = xfs_inode_buftarg(ip);
> struct block_device *bdev = target->bt_bdev;
>
> - stat->result_mask |= STATX_DIOALIGN;
> + stat->result_mask |= STATX_DIOALIGN | STATX_DIO_READ_ALIGN;

BTW, it would be a crappy userspace which can't handle fields which it
did not ask for, e.g. asked for STATX_DIOALIGN, but got STATX_DIOALIGN
and STATX_DIO_READ_ALIGN