From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_repair: don't obliterate return codes
Date: Wed, 8 Jan 2025 16:56:50 -0800 [thread overview]
Message-ID: <20250109005650.GK1306365@frogsfrogsfrogs> (raw)
From: Darrick J. Wong <djwong@kernel.org>
Don't clobber error here, it's err2 that's the temporary variable.
Coverity-id: 1637363
Fixes: b790ab2a303d58 ("xfs_repair: support quota inodes in the metadata directory")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
repair/quotacheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/repair/quotacheck.c b/repair/quotacheck.c
index 8c7339b267d8e6..7953144c3f416b 100644
--- a/repair/quotacheck.c
+++ b/repair/quotacheck.c
@@ -691,7 +691,7 @@ discover_quota_inodes(
err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_GROUP);
if (err2 && !error)
error = err2;
- error = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
+ err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
if (err2 && !error)
error = err2;
next reply other threads:[~2025-01-09 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 0:56 Darrick J. Wong [this message]
2025-01-09 6:08 ` [PATCH] xfs_repair: don't obliterate return codes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109005650.GK1306365@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox