* [PATCH] xfs_repair: don't obliterate return codes
@ 2025-01-09 0:56 Darrick J. Wong
2025-01-09 6:08 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2025-01-09 0:56 UTC (permalink / raw)
To: Andrey Albershteyn; +Cc: xfs
From: Darrick J. Wong <djwong@kernel.org>
Don't clobber error here, it's err2 that's the temporary variable.
Coverity-id: 1637363
Fixes: b790ab2a303d58 ("xfs_repair: support quota inodes in the metadata directory")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
repair/quotacheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/repair/quotacheck.c b/repair/quotacheck.c
index 8c7339b267d8e6..7953144c3f416b 100644
--- a/repair/quotacheck.c
+++ b/repair/quotacheck.c
@@ -691,7 +691,7 @@ discover_quota_inodes(
err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_GROUP);
if (err2 && !error)
error = err2;
- error = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
+ err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
if (err2 && !error)
error = err2;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_repair: don't obliterate return codes
2025-01-09 0:56 [PATCH] xfs_repair: don't obliterate return codes Darrick J. Wong
@ 2025-01-09 6:08 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2025-01-09 6:08 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Andrey Albershteyn, xfs
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-09 6:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 0:56 [PATCH] xfs_repair: don't obliterate return codes Darrick J. Wong
2025-01-09 6:08 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox